fix(cli): scss shouldn't be enabled (#10807)

ematipico · web-flow · commit d97fffe0aba0 · 2026-06-30T10:22:55.000+01:00
diff --git a/.changeset/fluffy-heads-wash.md b/.changeset/fluffy-heads-wash.md
@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed an issue where `.scss` files were incorrectly analyzed when running `biome check`.
diff --git a/crates/biome_cli/tests/commands/format.rs b/crates/biome_cli/tests/commands/format.rs
@@ -6,6 +6,7 @@ use crate::snap_test::{SnapshotPayload, assert_file_contents, markup_to_string};
 use crate::{
     CUSTOM_FORMAT_BEFORE, FORMATTED, LINT_ERROR, UNFORMATTED, assert_cli_snapshot, run_cli,
 };
+use biome_cli::CliDiagnostic;
 use biome_console::{BufferConsole, MarkupBuf, markup};
 use biome_fs::{FileSystemExt, MemoryFileSystem};
 use bpaf::Args;
@@ -4103,7 +4104,7 @@ fn trailing_newline_html_via_cli() {
 }
 
 #[test]
-fn harness_scss() {
+fn harness_scss_format() {
     let fs = MemoryFileSystem::default();
     let mut console = BufferConsole::default();
 
@@ -4116,10 +4117,33 @@ fn harness_scss() {
         Args::from(["format", file_path.as_str()].as_slice()),
     );
 
+    let result = result.expect_err("This test will fail once SCSS support is officially added");
+
     assert!(
-        result.is_err(),
-        "This test will fail once SCSS support is officially added"
+        matches!(result, CliDiagnostic::NoFilesWereProcessed(_)),
+        "Found: {result:?}"
+    )
+}
+
+#[test]
+fn harness_scss_lint() {
+    let fs = MemoryFileSystem::default();
+    let mut console = BufferConsole::default();
+
+    let file_path = Utf8Path::new("format.scss");
+    fs.insert(file_path.into(), "$fff".as_bytes());
+
+    let (_, result) = run_cli(
+        fs,
+        &mut console,
+        Args::from(["lint", file_path.as_str()].as_slice()),
     );
+    let result = result.expect_err("This test will fail once SCSS support is officially added");
+
+    assert!(
+        matches!(result, CliDiagnostic::NoFilesWereProcessed(_)),
+        "Found: {result:?}"
+    )
 }
 
 #[test]
diff --git a/crates/biome_css_formatter/Cargo.toml b/crates/biome_css_formatter/Cargo.toml
@@ -25,7 +25,7 @@ name    = "css_formatter"
 biome_css_syntax  = { workspace = true }
 biome_diagnostics = { workspace = true }
 biome_formatter   = { workspace = true }
-biome_languages   = { workspace = true, features = ["scss"] }
+biome_languages   = { workspace = true, features = ["lang_css"] }
 biome_rowan       = { workspace = true }
 biome_string_case = { workspace = true }
 biome_suppression = { workspace = true }
@@ -37,6 +37,7 @@ biome_css_syntax     = { path = "../biome_css_syntax", features = ["scss"] }
 biome_formatter      = { path = "../biome_formatter", features = ["countme"] }
 biome_formatter_test = { path = "../biome_formatter_test", features = ["lang_css"] }
 biome_fs             = { path = "../biome_fs" }
+biome_languages      = { path = "../biome_languages" }
 biome_parser         = { path = "../biome_parser" }
 biome_service        = { path = "../biome_service", features = ["lang_css"] }
 biome_test_utils     = { path = "../biome_test_utils", features = ["lang_css"] }
diff --git a/crates/biome_css_formatter/tests/spec_test.rs b/crates/biome_css_formatter/tests/spec_test.rs
@@ -1,6 +1,7 @@
 use biome_configuration::css::CssFormatterConfiguration;
 use biome_configuration::{Configuration, CssConfiguration};
 use biome_formatter_test::spec::{SpecSnapshot, SpecTestFile};
+use biome_languages::{CssFileSource, DocumentFileSource};
 use camino::Utf8Path;
 
 pub fn run(spec_input_file: &str, _expected_file: &str, test_directory: &str, _file_type: &str) {
@@ -21,7 +22,13 @@ pub fn run(spec_input_file: &str, _expected_file: &str, test_directory: &str, _f
         ..Default::default()
     };
 
-    let snapshot = SpecSnapshot::new(test_file, test_directory, config);
+    let is_scss = test_file.file_name().ends_with(".scss");
+    let mut snapshot = SpecSnapshot::new(test_file, test_directory, config);
+
+    if is_scss {
+        snapshot =
+            snapshot.with_document_file_source(DocumentFileSource::Css(CssFileSource::scss()));
+    }
 
     snapshot.test()
 }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@biomejs/biome": patch
 +---
++
 +Fixed an issue where `.scss` files were incorrectly analyzed when running `biome check`.