Skip to content

Commit 85133fb

Browse files
Moktoclaude
Mokto
and
claude
committed
fix(svelte): share script-block scope so cross-referenced bindings aren't flagged as unused
A Svelte component's `<script module>` and `<script>` compile to one module and share a top-level scope, but each block was analyzed as an isolated embedded snippet. A binding (import, function, or variable) declared in one block and used only in the other was therefore reported as unused by noUnusedImports / noUnusedVariables / useImportType. The workspace now also collects value/type references from Svelte source `<script>` snippets (not just template snippets), so a name referenced in the sibling block counts as used. Gated to Svelte, where the two blocks genuinely share a module scope; Vue/Astro are unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent f62fb8b commit 85133fb

8 files changed

Lines changed: 180 additions & 4 deletions

‎.changeset/fix-svelte-script-module-cross-references.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@biomejs/biome": patch
3+
---
4+
5+
Fixed false positives in `noUnusedImports`, `noUnusedVariables`, and `useImportType` for Svelte components that use both a `<script module>` and a `<script>` block. The two blocks compile to a single module and share a top-level scope, so a binding (import, function, or variable) declared in one block and used only in the other is no longer reported as unused.

‎crates/biome_js_analyze/tests/specs/correctness/noUnusedImports/valid-svelte-cross-script-imports.svelte‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
<!-- should not generate diagnostics -->
2+
<script module lang="ts">
3+
import { tick } from "svelte";
4+
5+
// `Snippet` is imported in the instance <script> below, but referenced here.
6+
export interface Props {
7+
row?: Snippet;
8+
}
9+
</script>
10+
11+
<script lang="ts">
12+
import type { Snippet } from "svelte";
13+
14+
const { row }: Props = $props();
15+
16+
// `tick` is imported in the module <script> above, but used only here.
17+
async function refresh() {
18+
await tick();
19+
}
20+
21+
refresh();
22+
</script>
23+
24+
<div>{row}</div>

‎crates/biome_js_analyze/tests/specs/correctness/noUnusedImports/valid-svelte-cross-script-imports.svelte.snap‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
---
2+
source: crates/biome_js_analyze/tests/spec_tests.rs
3+
expression: valid-svelte-cross-script-imports.svelte
4+
---
5+
# Input
6+
```svelte
7+
<!-- should not generate diagnostics -->
8+
<script module lang="ts">
9+
import { tick } from "svelte";
10+
11+
// `Snippet` is imported in the instance <script> below, but referenced here.
12+
export interface Props {
13+
row?: Snippet;
14+
}
15+
</script>
16+
17+
<script lang="ts">
18+
import type { Snippet } from "svelte";
19+
20+
const { row }: Props = $props();
21+
22+
// `tick` is imported in the module <script> above, but used only here.
23+
async function refresh() {
24+
await tick();
25+
}
26+
27+
refresh();
28+
</script>
29+
30+
<div>{row}</div>
31+
32+
```

‎crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/invalid-svelte-unused-module-binding.svelte‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<script module lang="ts">
2+
// Declared in the module script and referenced in neither block nor the
3+
// template: still reported as unused.
4+
function unusedHelper(): string {
5+
return "unused";
6+
}
7+
</script>
8+
9+
<script lang="ts">
10+
const value = 1;
11+
</script>
12+
13+
<p>{value}</p>

‎crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/invalid-svelte-unused-module-binding.svelte.snap‎

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
---
2+
source: crates/biome_js_analyze/tests/spec_tests.rs
3+
expression: invalid-svelte-unused-module-binding.svelte
4+
---
5+
# Input
6+
```svelte
7+
<script module lang="ts">
8+
// Declared in the module script and referenced in neither block nor the
9+
// template: still reported as unused.
10+
function unusedHelper(): string {
11+
return "unused";
12+
}
13+
</script>
14+
15+
<script lang="ts">
16+
const value = 1;
17+
</script>
18+
19+
<p>{value}</p>
20+
21+
```
22+
23+
# Diagnostics
24+
```
25+
invalid-svelte-unused-module-binding.svelte:4:10 lint/correctness/noUnusedVariables FIXABLE ━━━━━━━━━━
26+
27+
! This function unusedHelper is unused.
28+
29+
2 │ // Declared in the module script and referenced in neither block nor the
30+
3 │ // template: still reported as unused.
31+
> 4 │ function unusedHelper(): string {
32+
│ ^^^^^^^^^^^^
33+
5 │ return "unused";
34+
6 │ }
35+
36+
i Unused variables are often the result of typos, incomplete refactors, or other sources of bugs.
37+
38+
i Unsafe fix: If this is intentional, prepend unusedHelper with an underscore.
39+
40+
2 2 │ // Declared in the module script and referenced in neither block nor the
41+
3 3 │ // template: still reported as unused.
42+
4 │ - function·unusedHelper():·string·{
43+
4 │ + function·_unusedHelper():·string·{
44+
5 5 │ return "unused";
45+
6 6 │ }
46+
47+
48+
```

‎crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/valid-svelte-cross-script-references.svelte‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
<!-- should not generate diagnostics -->
2+
<script module lang="ts">
3+
// `<script module>` and `<script>` compile to one module and share a
4+
// top-level scope. These bindings are declared here but used only in the
5+
// instance script below, so they must not be reported as unused.
6+
function formatId(id: number): string {
7+
return `row-${id}`;
8+
}
9+
10+
const PREFIX = "row";
11+
</script>
12+
13+
<script lang="ts">
14+
const id = formatId(1);
15+
const label = `${PREFIX}-${id}`;
16+
</script>
17+
18+
<div data-id={id}>{label}</div>

‎crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/valid-svelte-cross-script-references.svelte.snap‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
---
2+
source: crates/biome_js_analyze/tests/spec_tests.rs
3+
expression: valid-svelte-cross-script-references.svelte
4+
---
5+
# Input
6+
```svelte
7+
<!-- should not generate diagnostics -->
8+
<script module lang="ts">
9+
// `<script module>` and `<script>` compile to one module and share a
10+
// top-level scope. These bindings are declared here but used only in the
11+
// instance script below, so they must not be reported as unused.
12+
function formatId(id: number): string {
13+
return `row-${id}`;
14+
}
15+
16+
const PREFIX = "row";
17+
</script>
18+
19+
<script lang="ts">
20+
const id = formatId(1);
21+
const label = `${PREFIX}-${id}`;
22+
</script>
23+
24+
<div data-id={id}>{label}</div>
25+
26+
```

‎crates/biome_service/src/workspace/server.rs‎

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -667,6 +667,7 @@ impl WorkspaceServer {
667667

668668
// Track value references from non-source snippets (templates)
669669
let mut value_references = EmbeddedValueReferences::default();
670+
let is_svelte = source.to_html_file_source().is_some_and(|s| s.is_svelte());
670671
for snippet in &embedded_snippets {
671672
if let Some(js_snippet) = snippet.as_js_embedded_snippet() {
672673
let Some(file_source) = self.get_source(snippet.file_source_index()) else {
@@ -675,8 +676,11 @@ impl WorkspaceServer {
675676
let Some(js_file_source) = file_source.to_js_file_source() else {
676677
continue;
677678
};
678-
// Only process non-source snippets (templates)
679-
if !js_file_source.is_embedded_source() {
679+
// Templates always; for Svelte also the sibling `<script>` blocks.
680+
// A Svelte component's `<script module>` and `<script>` compile to
681+
// one module and share a top-level scope, so a binding used only in
682+
// the other block must still count as used.
683+
if !js_file_source.is_embedded_source() || is_svelte {
680684
let mut builder = value_references.builder();
681685
builder.visit_non_source_snippet(&js_snippet.parse.tree());
682686
value_references.finish(builder);
@@ -2145,6 +2149,9 @@ impl Workspace for WorkspaceServer {
21452149

21462150
// Track value references from non-source snippets (templates)
21472151
let mut value_references = EmbeddedValueReferences::default();
2152+
let is_svelte = document_source
2153+
.to_html_file_source()
2154+
.is_some_and(|s| s.is_svelte());
21482155
for snippet in &embedded_snippets {
21492156
if let Some(js_snippet) = snippet.as_js_embedded_snippet() {
21502157
let Some(file_source) = self.get_source(snippet.file_source_index()) else {
@@ -2153,8 +2160,11 @@ impl Workspace for WorkspaceServer {
21532160
let Some(js_file_source) = file_source.to_js_file_source() else {
21542161
continue;
21552162
};
2156-
// Only process non-source snippets (templates)
2157-
if !js_file_source.is_embedded_source() {
2163+
// Templates always; for Svelte also the sibling `<script>` blocks.
2164+
// A Svelte component's `<script module>` and `<script>` compile to
2165+
// one module and share a top-level scope, so a binding used only in
2166+
// the other block must still count as used.
2167+
if !js_file_source.is_embedded_source() || is_svelte {
21582168
let mut builder = value_references.builder();
21592169
builder.visit_non_source_snippet(&js_snippet.parse.tree());
21602170
value_references.finish(builder);

0 commit comments

Comments
 (0)