Skip to content

[Compat] Don't use uint32_t for z_crc_t#1344

Merged
Dead2 merged 1 commit intozlib-ng:developfrom
mtl1979:z_crc_t_fix1
Sep 26, 2022
Merged

[Compat] Don't use uint32_t for z_crc_t#1344
Dead2 merged 1 commit intozlib-ng:developfrom
mtl1979:z_crc_t_fix1

Conversation

@mtl1979
Copy link
Copy Markdown
Collaborator

@mtl1979 mtl1979 commented Sep 11, 2022

  • We don't include stdint.h as it must be included before stdarg.h and other headers might include stdarg.h before us

See #1342

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 11, 2022

Codecov Report

Merging #1344 (33b82d4) into develop (ce01b1e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1344   +/-   ##
========================================
  Coverage    84.17%   84.17%           
========================================
  Files          120      120           
  Lines        10438    10438           
  Branches      2657     2657           
========================================
  Hits          8786     8786           
- Misses        1029     1031    +2     
+ Partials       623      621    -2     
Flag Coverage Δ
macos_clang 41.94% <ø> (ø)
macos_gcc 73.83% <ø> (ø)
ubuntu_clang 83.70% <ø> (-0.18%) ⬇️
ubuntu_clang_debug 83.26% <ø> (-0.18%) ⬇️
ubuntu_clang_inflate_allow_invalid_dist 83.52% <ø> (+0.17%) ⬆️
ubuntu_clang_inflate_strict 83.86% <ø> (ø)
ubuntu_clang_mmap 84.20% <ø> (ø)
ubuntu_clang_pigz 40.08% <ø> (ø)
ubuntu_clang_pigz_no_optim 41.49% <ø> (ø)
ubuntu_clang_pigz_no_threads 39.67% <ø> (ø)
ubuntu_clang_reduced_mem 84.37% <ø> (ø)
ubuntu_gcc 75.72% <ø> (+0.06%) ⬆️
ubuntu_gcc_aarch64 77.43% <ø> (ø)
ubuntu_gcc_aarch64_compat_no_opt 75.59% <ø> (ø)
ubuntu_gcc_aarch64_no_acle 76.15% <ø> (ø)
ubuntu_gcc_aarch64_no_neon 76.15% <ø> (ø)
ubuntu_gcc_armhf 77.37% <ø> (ø)
ubuntu_gcc_armhf_compat_no_opt 75.46% <ø> (ø)
ubuntu_gcc_armhf_no_acle 77.40% <ø> (ø)
ubuntu_gcc_armhf_no_neon 77.29% <ø> (ø)
ubuntu_gcc_armsf 77.20% <ø> (ø)
ubuntu_gcc_armsf_compat_no_opt 75.35% <ø> (ø)
ubuntu_gcc_compat_no_opt 76.96% <ø> (-0.03%) ⬇️
ubuntu_gcc_compat_sprefix 74.11% <ø> (ø)
ubuntu_gcc_m32 73.61% <ø> (ø)
ubuntu_gcc_mingw_i686 0.00% <ø> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <ø> (ø)
ubuntu_gcc_no_avx2 74.75% <ø> (ø)
ubuntu_gcc_no_ctz 74.97% <ø> (ø)
ubuntu_gcc_no_ctzll 75.00% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 73.99% <ø> (ø)
ubuntu_gcc_no_sse2 74.95% <ø> (ø)
ubuntu_gcc_no_sse4 74.62% <ø> (ø)
ubuntu_gcc_o1 74.51% <ø> (ø)
ubuntu_gcc_osb ∅ <ø> (∅)
ubuntu_gcc_pigz 37.96% <ø> (+0.05%) ⬆️
ubuntu_gcc_pigz_aarch64 38.92% <ø> (-0.03%) ⬇️
ubuntu_gcc_ppc 73.73% <ø> (ø)
ubuntu_gcc_ppc64 74.60% <ø> (ø)
ubuntu_gcc_ppc64le 74.54% <ø> (ø)
ubuntu_gcc_ppc_no_power8 74.67% <ø> (ø)
ubuntu_gcc_s390x 75.00% <ø> (ø)
ubuntu_gcc_s390x_dfltcc 72.23% <ø> (ø)
ubuntu_gcc_s390x_dfltcc_compat 73.76% <ø> (ø)
ubuntu_gcc_s390x_no_crc32 74.78% <ø> (ø)
ubuntu_gcc_sparc64 74.89% <ø> (ø)
ubuntu_gcc_sprefix 73.91% <ø> (ø)
win64_gcc 74.09% <ø> (ø)
win64_gcc_compat_no_opt 74.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gzlib.c 70.60% <0.00%> (ø)
test/minideflate.c 45.22% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nmoinvaz nmoinvaz added Compatibility API/ABI Compatibility issue Build Env labels Sep 11, 2022
* We don't include stdint.h as it must be included before stdarg.h and other headers might include stdarg.h before us

See zlib-ng#1342
Copy link
Copy Markdown
Member

@Dead2 Dead2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dead2 Dead2 merged commit 6057002 into zlib-ng:develop Sep 26, 2022
@Dead2 Dead2 mentioned this pull request Dec 27, 2022
Dead2 added a commit that referenced this pull request Mar 7, 2023
Changes since 2.0.6:
- Fix CVE-2022-37434 #1328
- Fix chunkmemset #1196
- Fix deflateBound too small #1236
- Fix Z_SOLO #1263
- Fix ACLE variant of crc32 #1274
- Fix inflateBack #1311
- Fix deflate_quick windowsize #1431
- Fix DFLTCC bugs related to adler32 #1349 and #1390
- Fix warnings #1194 #1312 #1362
- MacOS build fix #1198
- Add invalid windowBits handling #1293
- Support for Force TZCNT #1186
- Support for aligned_alloc() #1360
- Minideflate improvements #1175 #1238
- Dont use unaligned access for memcpy #1309
- Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365
- Test improvements #1208 #1227 #1241 #1353
- Cleanup #1266
- Documentation #1205 #1359
- Misc improvements #1294 #1297 #1306 #1344 #1348
- Backported zlib fixes
- Backported CI workflows from Develop branch
Dead2 added a commit that referenced this pull request Mar 17, 2023
Changes since 2.0.6:
- Fix CVE-2022-37434 #1328
- Fix chunkmemset #1196
- Fix deflateBound too small #1236
- Fix Z_SOLO #1263
- Fix ACLE variant of crc32 #1274
- Fix inflateBack #1311
- Fix deflate_quick windowsize #1431
- Fix DFLTCC bugs related to adler32 #1349 and #1390
- Fix warnings #1194 #1312 #1362
- MacOS build fix #1198
- Add invalid windowBits handling #1293
- Support for Force TZCNT #1186
- Support for aligned_alloc() #1360
- Minideflate improvements #1175 #1238
- Dont use unaligned access for memcpy #1309
- Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365
- Test improvements #1208 #1227 #1241 #1353
- Cleanup #1266
- Documentation #1205 #1359
- Misc improvements #1294 #1297 #1306 #1344 #1348
- Backported zlib fixes
- Backported CI workflows from Develop branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Env Compatibility API/ABI Compatibility issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants