Fix incorrect character case of the CMAKE_INTERPROCEDURAL_OPTIMIZATION_* names#1267
Merged
Dead2 merged 1 commit intozlib-ng:developfrom May 6, 2022
Merged
Fix incorrect character case of the CMAKE_INTERPROCEDURAL_OPTIMIZATION_* names#1267Dead2 merged 1 commit intozlib-ng:developfrom
Dead2 merged 1 commit intozlib-ng:developfrom
Conversation
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Codecov Report
@@ Coverage Diff @@
## develop #1267 +/- ##
===========================================
+ Coverage 87.29% 87.34% +0.04%
===========================================
Files 115 115
Lines 10202 10202
Branches 2574 2574
===========================================
+ Hits 8906 8911 +5
+ Misses 967 963 -4
+ Partials 329 328 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Dead2
approved these changes
May 6, 2022
Member
Dead2
left a comment
There was a problem hiding this comment.
I don't fully understand why this fix is needed, but it looks good to me.
Contributor
Author
|
For example, parent project: In zlib-ng, the CMAKE_INTERPROCEDURAL_OPTIMIZATION_RELEASE variable will not be overwritten (PR #1233) and CMake controlled LTO will not be disabled. When developing PR #1233, I missed the point that the variable names in CMake are case-sensitive, and in the CMAKE_CONFIGURATION_TYPES list, configuration names are not in upper case :( |
Member
|
@phprus Ah, now it makes sense, thanks for explaining it. 👍 |
Merged
Dead2
added a commit
that referenced
this pull request
Mar 7, 2023
Changes since 2.0.6: - Fix CVE-2022-37434 #1328 - Fix chunkmemset #1196 - Fix deflateBound too small #1236 - Fix Z_SOLO #1263 - Fix ACLE variant of crc32 #1274 - Fix inflateBack #1311 - Fix deflate_quick windowsize #1431 - Fix DFLTCC bugs related to adler32 #1349 and #1390 - Fix warnings #1194 #1312 #1362 - MacOS build fix #1198 - Add invalid windowBits handling #1293 - Support for Force TZCNT #1186 - Support for aligned_alloc() #1360 - Minideflate improvements #1175 #1238 - Dont use unaligned access for memcpy #1309 - Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365 - Test improvements #1208 #1227 #1241 #1353 - Cleanup #1266 - Documentation #1205 #1359 - Misc improvements #1294 #1297 #1306 #1344 #1348 - Backported zlib fixes - Backported CI workflows from Develop branch
Dead2
added a commit
that referenced
this pull request
Mar 17, 2023
Changes since 2.0.6: - Fix CVE-2022-37434 #1328 - Fix chunkmemset #1196 - Fix deflateBound too small #1236 - Fix Z_SOLO #1263 - Fix ACLE variant of crc32 #1274 - Fix inflateBack #1311 - Fix deflate_quick windowsize #1431 - Fix DFLTCC bugs related to adler32 #1349 and #1390 - Fix warnings #1194 #1312 #1362 - MacOS build fix #1198 - Add invalid windowBits handling #1293 - Support for Force TZCNT #1186 - Support for aligned_alloc() #1360 - Minideflate improvements #1175 #1238 - Dont use unaligned access for memcpy #1309 - Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365 - Test improvements #1208 #1227 #1241 #1353 - Cleanup #1266 - Documentation #1205 #1359 - Misc improvements #1294 #1297 #1306 #1344 #1348 - Backported zlib fixes - Backported CI workflows from Develop branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The names
CMAKE_INTERPROCEDURAL_OPTIMIZATION_*must be uppercase.Variable names in CMake are case-sensitive.
Bug in PR #1233.
LTO will not be disabled in zlib-ng only if in the parent project any of the
CMAKE_INTERPROCEDURAL_OPTIMIZATION_{RELEASE,RELWITHDEBINFO, * }variables are defined toON.If the parent project defined only
CMAKE_INTERPROCEDURAL_OPTIMIZATIONeverything works fine.