macOs M1 build fix on arm cpu checks.#1198
Merged
Dead2 merged 1 commit intozlib-ng:developfrom Apr 27, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1198 +/- ##
===========================================
- Coverage 87.38% 87.33% -0.05%
===========================================
Files 114 114
Lines 10146 10146
Branches 2554 2554
===========================================
- Hits 8866 8861 -5
- Misses 956 961 +5
Partials 324 324
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mtl1979
reviewed
Mar 18, 2022
arch/arm/arm_features.c
Outdated
| # define ID_AA64ISAR0_CRC32_VAL ID_AA64ISAR0_CRC32 | ||
| # endif | ||
| #elif defined(__APPLE__) | ||
| # define _DARWIN_C_SOURCE /* enable types aliases (eg u_int) */ |
Collaborator
There was a problem hiding this comment.
This might break if zlib-ng is included by another project... Like other similar preprocessor defines, it should always be guarded.
Contributor
Author
There was a problem hiding this comment.
sorry I missed your comment.
Member
|
What error does this fix? |
d3ab1ac to
df42862
Compare
Contributor
Author
It enables type aliases such as u_int .. etc |
df42862 to
676a433
Compare
mtl1979
approved these changes
Apr 26, 2022
Collaborator
mtl1979
left a comment
There was a problem hiding this comment.
Preferred way would be to add _DARWIN_C_SOURCE to whole project, but we don't use regular expressions, so mixing source files with and without the define is considered safe. We also do the same with other similar defines. The relevant manual page would be compat.5 on affected systems.
Merged
Dead2
added a commit
that referenced
this pull request
Mar 7, 2023
Changes since 2.0.6: - Fix CVE-2022-37434 #1328 - Fix chunkmemset #1196 - Fix deflateBound too small #1236 - Fix Z_SOLO #1263 - Fix ACLE variant of crc32 #1274 - Fix inflateBack #1311 - Fix deflate_quick windowsize #1431 - Fix DFLTCC bugs related to adler32 #1349 and #1390 - Fix warnings #1194 #1312 #1362 - MacOS build fix #1198 - Add invalid windowBits handling #1293 - Support for Force TZCNT #1186 - Support for aligned_alloc() #1360 - Minideflate improvements #1175 #1238 - Dont use unaligned access for memcpy #1309 - Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365 - Test improvements #1208 #1227 #1241 #1353 - Cleanup #1266 - Documentation #1205 #1359 - Misc improvements #1294 #1297 #1306 #1344 #1348 - Backported zlib fixes - Backported CI workflows from Develop branch
Dead2
added a commit
that referenced
this pull request
Mar 17, 2023
Changes since 2.0.6: - Fix CVE-2022-37434 #1328 - Fix chunkmemset #1196 - Fix deflateBound too small #1236 - Fix Z_SOLO #1263 - Fix ACLE variant of crc32 #1274 - Fix inflateBack #1311 - Fix deflate_quick windowsize #1431 - Fix DFLTCC bugs related to adler32 #1349 and #1390 - Fix warnings #1194 #1312 #1362 - MacOS build fix #1198 - Add invalid windowBits handling #1293 - Support for Force TZCNT #1186 - Support for aligned_alloc() #1360 - Minideflate improvements #1175 #1238 - Dont use unaligned access for memcpy #1309 - Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365 - Test improvements #1208 #1227 #1241 #1353 - Cleanup #1266 - Documentation #1205 #1359 - Misc improvements #1294 #1297 #1306 #1344 #1348 - Backported zlib fixes - Backported CI workflows from Develop branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.