Skip to content

Fixed trailing whitespaces and missing new lines.#1040

Merged
Dead2 merged 1 commit intozlib-ng:developfrom
nmoinvaz:improvements/formatting-whitespace
Sep 22, 2021
Merged

Fixed trailing whitespaces and missing new lines.#1040
Dead2 merged 1 commit intozlib-ng:developfrom
nmoinvaz:improvements/formatting-whitespace

Conversation

@nmoinvaz
Copy link
Copy Markdown
Member

@nmoinvaz nmoinvaz commented Sep 4, 2021

See issue #1038

@nmoinvaz nmoinvaz added the cleanup Improving maintainability or removing code. label Sep 4, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 4, 2021 •
edited
Loading

Codecov Report

Merging #1040 (b51ff84) into develop (e9d0177) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1040      +/-   ##
===========================================
- Coverage    76.29%   76.28%   -0.02%     
===========================================
  Files           85       85              
  Lines         8728     8728              
  Branches      1397     1397              
===========================================
- Hits          6659     6658       -1     
  Misses        1527     1527              
- Partials       542      543       +1
Flag Coverage Δ
macos_clang 68.07% <ø> (ø)
macos_gcc 66.70% <ø> (ø)
ubuntu_clang 67.13% <ø> (ø)
ubuntu_clang_debug 66.41% <ø> (ø)
ubuntu_clang_inflate_allow_invalid_dist 66.90% <ø> (ø)
ubuntu_clang_inflate_strict 67.12% <ø> (ø)
ubuntu_clang_mmap 67.13% <ø> (ø)
ubuntu_clang_msan 67.13% <ø> (ø)
ubuntu_clang_pigz 31.64% <ø> (ø)
ubuntu_clang_pigz_no_optim 37.75% <ø> (ø)
ubuntu_clang_pigz_no_threads 31.29% <ø> (ø)
ubuntu_clang_reduced_mem 67.39% <ø> (ø)
ubuntu_gcc 66.16% <ø> (ø)
ubuntu_gcc_aarch64 69.11% <ø> (ø)
ubuntu_gcc_aarch64_compat_no_opt 67.37% <ø> (ø)
ubuntu_gcc_aarch64_no_acle 68.07% <ø> (ø)
ubuntu_gcc_aarch64_no_neon 68.35% <ø> (ø)
ubuntu_gcc_armhf 69.08% <ø> (ø)
ubuntu_gcc_armhf_compat_no_opt 67.31% <ø> (ø)
ubuntu_gcc_armhf_no_acle 69.26% <ø> (ø)
ubuntu_gcc_armhf_no_neon 69.48% <ø> (ø)
ubuntu_gcc_armsf 69.10% <ø> (ø)
ubuntu_gcc_armsf_compat_no_opt 67.31% <ø> (ø)
ubuntu_gcc_compat_no_opt 68.79% <ø> (ø)
ubuntu_gcc_mingw_i686 0.00% <ø> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <ø> (ø)
ubuntu_gcc_no_avx2 69.12% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 64.31% <ø> (ø)
ubuntu_gcc_no_sse2 66.92% <ø> (ø)
ubuntu_gcc_no_sse4 66.18% <ø> (ø)
ubuntu_gcc_o3 66.76% <ø> (ø)
ubuntu_gcc_osb 68.37% <ø> (ø)
ubuntu_gcc_pigz 31.89% <ø> (+0.02%) ⬆️
ubuntu_gcc_pigz_aarch64 35.92% <ø> (-0.07%) ⬇️
ubuntu_gcc_ppc 66.96% <ø> (ø)
ubuntu_gcc_ppc64 70.23% <ø> (ø)
ubuntu_gcc_ppc64le 68.62% <ø> (ø)
ubuntu_gcc_ppc_no_power8 69.50% <ø> (ø)
ubuntu_gcc_s390x 68.68% <ø> (ø)
ubuntu_gcc_sparc64 70.60% <ø> (ø)
win64_gcc ∅ <ø> (∅)
win64_gcc_compat_no_opt ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
deflate_fast.c 90.69% <ø> (ø)
inffast.c 88.69% <ø> (ø)
insert_string_tpl.h 96.87% <ø> (ø)
functable.c 75.95% <0.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d0177...b51ff84. Read the comment docs.

@dzenanz dzenanz mentioned this pull request Sep 6, 2021
Closed
mtl1979
mtl1979 approved these changes Sep 6, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mtl1979 mtl1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Sep 7, 2021
Merged
Closed
hjmjohnson
hjmjohnson approved these changes Sep 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These minor changes make a big difference for external developers working with source code of many different packages.

Thanks!

@dzenanz dzenanz mentioned this pull request Sep 21, 2021
Merged
@Dead2 Dead2 merged commit f77af71 into zlib-ng:develop Sep 22, 2021
@hjmjohnson
Copy link
Copy Markdown
Contributor

hjmjohnson commented Sep 22, 2021

Thank you!

@dzenanz dzenanz mentioned this pull request Sep 22, 2021
Closed
Dead2 added a commit that referenced this pull request Dec 13, 2021
@Dead2
Version 2.0.6
2cf68ab 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050
@Dead2 Dead2 mentioned this pull request Dec 13, 2021
Merged
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
4c43f09 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
0436e5c 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
a7d7aea 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
5618c06 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
9f99d5b 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067 #1079
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 24, 2021
@Dead2
Version 2.0.6
b56a2fd 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067 #1079
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hjmjohnson hjmjohnson hjmjohnson approved these changes

@mtl1979 mtl1979 mtl1979 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cleanup Improving maintainability or removing code.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nmoinvaz @hjmjohnson @mtl1979 @Dead2