Skip to content

Fix Z_SOLO mode#1022

Merged
Dead2 merged 1 commit intozlib-ng:stablefrom
berolinux:fixes/Z_SOLO
Aug 11, 2021
Merged

Fix Z_SOLO mode#1022
Dead2 merged 1 commit intozlib-ng:stablefrom
berolinux:fixes/Z_SOLO

Conversation

@berolinux
Copy link
Copy Markdown
Contributor

@berolinux berolinux commented Jun 27, 2021

Without this patch, #include <zlib.h> with Z_SOLO defined
(e.g. while building perl 5.34.0) fails because of use of
undefined types.

@berolinux
Fix Z_SOLO mode
24098a6 
Without this patch, #include <zlib.h> with Z_SOLO defined
(e.g. while building perl 5.34.0) fails because of use of
undefined types.
@Dead2 Dead2 requested a review from nmoinvaz June 29, 2021 20:49
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 29, 2021 •
edited
Loading

Codecov Report

Merging #1022 (24098a6) into stable (c69f78b) will decrease coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #1022      +/-   ##
==========================================
- Coverage   78.08%   77.65%   -0.44%     
==========================================
  Files          74       74              
  Lines        8315     8325      +10     
  Branches     1364     1365       +1     
==========================================
- Hits         6493     6465      -28     
- Misses       1296     1329      +33     
- Partials      526      531       +5
Flag Coverage Δ
macos_clang 68.58% <ø> (ø)
macos_gcc 67.45% <ø> (ø)
ubuntu_clang 72.39% <ø> (-2.63%) ⬇️
ubuntu_clang_debug 72.59% <ø> (-2.74%) ⬇️
ubuntu_clang_inflate_allow_invalid_dist 72.12% <ø> (-2.62%) ⬇️
ubuntu_clang_inflate_strict 72.38% <ø> (-2.63%) ⬇️
ubuntu_clang_mmap 72.09% <ø> (-2.62%) ⬇️
ubuntu_clang_msan 72.39% <ø> (-2.63%) ⬇️
ubuntu_clang_pigz 31.81% <ø> (-2.62%) ⬇️
ubuntu_clang_pigz_no_optim 37.40% <ø> (+0.37%) ⬆️
ubuntu_clang_pigz_no_threads 31.54% <ø> (-2.59%) ⬇️
ubuntu_gcc 71.78% <ø> (-2.83%) ⬇️
ubuntu_gcc_aarch64 74.79% <ø> (-0.09%) ⬇️
ubuntu_gcc_aarch64_compat_no_opt 72.53% <ø> (-1.23%) ⬇️
ubuntu_gcc_aarch64_no_acle 73.93% <ø> (-0.10%) ⬇️
ubuntu_gcc_aarch64_no_neon 74.45% <ø> (-0.10%) ⬇️
ubuntu_gcc_armhf 74.81% <ø> (-0.09%) ⬇️
ubuntu_gcc_armhf_compat_no_opt 72.52% <ø> (-1.24%) ⬇️
ubuntu_gcc_armhf_no_acle 75.00% <ø> (-0.09%) ⬇️
ubuntu_gcc_armhf_no_neon 75.43% <ø> (-0.10%) ⬇️
ubuntu_gcc_armsf 74.82% <ø> (-0.09%) ⬇️
ubuntu_gcc_armsf_compat_no_opt 72.52% <ø> (-1.24%) ⬇️
ubuntu_gcc_compat_no_opt 73.65% <ø> (-1.21%) ⬇️
ubuntu_gcc_mingw_i686 0.00% <ø> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <ø> (ø)
ubuntu_gcc_no_avx2 74.82% <ø> (-0.09%) ⬇️
ubuntu_gcc_no_pclmulqdq 70.16% <ø> (-2.98%) ⬇️
ubuntu_gcc_no_sse2 72.83% <ø> (-1.33%) ⬇️
ubuntu_gcc_no_sse4 71.32% <ø> (-2.00%) ⬇️
ubuntu_gcc_o3 72.59% <ø> (-1.90%) ⬇️
ubuntu_gcc_osb 74.77% <ø> (-2.70%) ⬇️
ubuntu_gcc_pigz 31.72% <ø> (-2.87%) ⬇️
ubuntu_gcc_pigz_aarch64 35.99% <ø> (+0.35%) ⬆️
ubuntu_gcc_ppc 75.16% <ø> (-0.09%) ⬇️
ubuntu_gcc_ppc64 75.93% <ø> (-0.09%) ⬇️
ubuntu_gcc_ppc64le 74.69% <ø> (-0.10%) ⬇️
ubuntu_gcc_s390x 73.58% <ø> (-0.05%) ⬇️
ubuntu_gcc_sparc64 76.40% <ø> (-0.09%) ⬇️
win64_gcc 70.22% <ø> (ø)
win64_gcc_compat_no_opt 73.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
match_tpl.h 72.72% <0.00%> (-27.28%) ⬇️
inftrees.c 86.33% <0.00%> (-11.52%) ⬇️
chunkset_tpl.h 94.64% <0.00%> (-4.48%) ⬇️
trees.c 96.21% <0.00%> (-0.28%) ⬇️
trees_emit.h 100.00% <0.00%> (+4.93%) ⬆️
deflate.h 57.14% <0.00%> (+9.31%) ⬆️
zutil_p.h 85.71% <0.00%> (+19.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69f78b...24098a6. Read the comment docs.

@nmoinvaz
Copy link
Copy Markdown
Member

nmoinvaz commented Jun 30, 2021 •
edited
Loading

I suggest only doing one PR and @Dead2 can cherry-pick the change into stable if he thinks it is necessary. I will just comment on the one targeting develop branch for now.

@Dead2 Dead2 merged commit ac97954 into zlib-ng:stable Aug 11, 2021
Dead2 added a commit that referenced this pull request Dec 13, 2021
@Dead2
Version 2.0.6
2cf68ab 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050
@Dead2 Dead2 mentioned this pull request Dec 13, 2021
Merged
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
4c43f09 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
0436e5c 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
a7d7aea 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
5618c06 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
@Dead2
Version 2.0.6
9f99d5b 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067 #1079
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 24, 2021
@Dead2
Version 2.0.6
b56a2fd 
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067 #1079
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
@Dead2 Dead2 mentioned this pull request Apr 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmoinvaz nmoinvaz Awaiting requested review from nmoinvaz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@berolinux @nmoinvaz @Dead2