Skip to content

Fix hangs on macOS due to loading of misaligned addresses in chunkmemset_8.#1031

Merged
Dead2 merged 1 commit intozlib-ng:developfrom
sergio-nsk:analigned
Sep 3, 2021
Merged

Fix hangs on macOS due to loading of misaligned addresses in chunkmemset_8.#1031
Dead2 merged 1 commit intozlib-ng:developfrom
sergio-nsk:analigned

Conversation

@sergio-nsk
Copy link
Copy Markdown
Contributor

No description provided.

@sergio-nsk sergio-nsk force-pushed the analigned branch 3 times, most recently from 3329871 to 1e688c2 Compare July 22, 2021 20:14
@Dead2
Copy link
Copy Markdown
Member

Dead2 commented Aug 11, 2021

LGTM after the indentation has been fixed.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 11, 2021

Codecov Report

Merging #1031 (88b7f5d) into develop (12a975a) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1031      +/-   ##
===========================================
- Coverage    77.91%   77.72%   -0.19%     
===========================================
  Files           81       82       +1     
  Lines         8389     8466      +77     
  Branches      1371     1383      +12     
===========================================
+ Hits          6536     6580      +44     
- Misses        1320     1353      +33     
  Partials       533      533              
Flag Coverage Δ
macos_clang 68.05% <100.00%> (+<0.01%) ⬆️
macos_gcc 66.75% <100.00%> (ø)
ubuntu_clang 73.35% <0.00%> (+1.52%) ⬆️
ubuntu_clang_debug 73.74% <0.00%> (+1.56%) ⬆️
ubuntu_clang_inflate_allow_invalid_dist 73.10% <0.00%> (+1.51%) ⬆️
ubuntu_clang_inflate_strict 73.34% <0.00%> (+1.51%) ⬆️
ubuntu_clang_mmap 73.33% <0.00%> (+1.51%) ⬆️
ubuntu_clang_msan 73.35% <0.00%> (+1.52%) ⬆️
ubuntu_clang_pigz 34.18% <0.00%> (+2.49%) ⬆️
ubuntu_clang_pigz_no_optim 38.35% <100.00%> (+0.51%) ⬆️
ubuntu_clang_pigz_no_threads 33.72% <0.00%> (+2.37%) ⬆️
ubuntu_clang_reduced_mem 73.62% <0.00%> (+1.53%) ⬆️
ubuntu_gcc 72.84% <0.00%> (+1.73%) ⬆️
ubuntu_gcc_aarch64 74.67% <100.00%> (+0.19%) ⬆️
ubuntu_gcc_aarch64_compat_no_opt 72.30% <100.00%> (+0.09%) ⬆️
ubuntu_gcc_aarch64_no_acle 73.95% <100.00%> (+0.19%) ⬆️
ubuntu_gcc_aarch64_no_neon 74.22% <100.00%> (+0.20%) ⬆️
ubuntu_gcc_armhf 74.67% <100.00%> (+0.19%) ⬆️
ubuntu_gcc_armhf_compat_no_opt 72.27% <100.00%> (+0.09%) ⬆️
ubuntu_gcc_armhf_no_acle 74.92% <100.00%> (+0.19%) ⬆️
ubuntu_gcc_armhf_no_neon 75.16% <100.00%> (+0.19%) ⬆️
ubuntu_gcc_armsf 74.68% <100.00%> (+0.19%) ⬆️
ubuntu_gcc_armsf_compat_no_opt 72.27% <100.00%> (+0.09%) ⬆️
ubuntu_gcc_compat_no_opt 73.43% <100.00%> (+0.09%) ⬆️
ubuntu_gcc_mingw_i686 0.00% <0.00%> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <0.00%> (ø)
ubuntu_gcc_no_avx2 74.80% <100.00%> (+0.18%) ⬆️
ubuntu_gcc_no_pclmulqdq 71.32% <0.00%> (+1.85%) ⬆️
ubuntu_gcc_no_sse2 73.89% <100.00%> (+1.79%) ⬆️
ubuntu_gcc_no_sse4 71.64% <0.00%> (+0.19%) ⬆️
ubuntu_gcc_o3 72.03% <0.00%> (+0.12%) ⬆️
ubuntu_gcc_osb 75.85% <0.00%> (+1.76%) ⬆️
ubuntu_gcc_pigz 34.41% <0.00%> (+2.70%) ⬆️
ubuntu_gcc_pigz_aarch64 36.24% <100.00%> (+0.40%) ⬆️
ubuntu_gcc_ppc 72.57% <0.00%> (-0.57%) ⬇️
ubuntu_gcc_ppc64 74.69% <100.00%> (-1.05%) ⬇️
ubuntu_gcc_ppc64le 73.28% <100.00%> (-1.04%) ⬇️
ubuntu_gcc_ppc_no_power8 75.20% <100.00%> (?)
ubuntu_gcc_s390x 73.99% <100.00%> (+0.19%) ⬆️
ubuntu_gcc_sparc64 76.35% <100.00%> (+0.20%) ⬆️
win64_gcc ∅ <ø> (∅)
win64_gcc_compat_no_opt ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chunkset_tpl.h 95.65% <100.00%> (+1.00%) ⬆️
deflate_p.h 51.28% <0.00%> (-48.72%) ⬇️
zutil_p.h 71.42% <0.00%> (-28.58%) ⬇️
arch/power/power.c 71.42% <0.00%> (-3.58%) ⬇️
functable.c 75.00% <0.00%> (-0.63%) ⬇️
gzlib.c 56.38% <0.00%> (-0.36%) ⬇️
adler32_p.h 100.00% <0.00%> (ø)
arch/power/slide_hash_power8.c
arch/power/adler32_vmx.c 0.00% <0.00%> (ø)
arch/power/slide_ppc_tpl.h 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a975a...88b7f5d. Read the comment docs.

@Dead2 Dead2 merged commit e9d0177 into zlib-ng:develop Sep 3, 2021
@nmoinvaz nmoinvaz added the bug label Sep 3, 2021
Dead2 added a commit that referenced this pull request Dec 13, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050
@Dead2 Dead2 mentioned this pull request Dec 13, 2021
Dead2 added a commit that referenced this pull request Dec 20, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1071
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 20, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067 #1079
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
Dead2 added a commit that referenced this pull request Dec 24, 2021
 - Fix hangs on macOS #1031
 - Fix minideflate write buffers being overwritten #1060
 - Fix deflateBound and compressBound returning too small size estimates #1049 #1071
 - Fix incorrect function declaration warning #1080
 - Fix build problems when building outside of source dir #1049
 - Fix build problems on arm2-7 #1030
 - Fixed some compile warnings #1020 #1036 #1037 #1048
 - Improved posix memalign support #888
 - Improvements to testing #637 #1026 #1032 #1035 #1049 #1051 #1056 #1063 #1067 #1079
 - Improvements for integration into other projects #1022 #1042
 - Code style fixes #637 #1040 #1050 #1075
@sergio-nsk sergio-nsk deleted the analigned branch April 22, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants