Codecov Report

Merging #1032 (37265e8) into develop (071e4da) will increase coverage by 2.13%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1032      +/-   ##
===========================================
+ Coverage    79.44%   81.57%   +2.13%     
===========================================
  Files           85       85              
  Lines         8663     8667       +4     
  Branches      1400     1401       +1     
===========================================
+ Hits          6882     7070     +188     
+ Misses        1233     1057     -176     
+ Partials       548      540       -8     

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071e4da...37265e8. Read the comment docs.

Fails CI...

@mtl1979 That's expected - sorry, I should've been more explicit about this. The new builder is currently linked to my fork of zlib-ng, not to the main repo. A token is needed in order to link it to the main repo, which only the admin (@Dead2 I guess?) has access to. So he should either share the token with me, so that I could reconfigure the builder, or, preferably, reconfigure the builder himself - not only because I'm lazy, but also to make sure that the instructions I wrote are adequate.

@iii-i Nobody can review the full pull request until @Dead2 makes the necessary changes... For controversial changes, at least two long-time developers need to review.

@Dead2 ping :-) Could you take a look please?

@iii-i I have not forgotten about this (or other PRs), it is just an extremely hectic period for me currently. Past 6 weeks I have barely been able to do any relaxing at all, and this will probably continue for a couple more weeks due to finishing up on the stuff currently going on plus we are moving offices starting next week. Hopefully things will be back to normal soon, and I can start doing the things I actually want to do again. 😄

In the mean time, anything small and approved by others I will probably merge, but anything bigger or things I think needs some extra scrutiny/testing from me, I am unfortunately unable to make the time for. Very sorry about that.

Rebased, added ephemeral runner support (https://github.blog/changelog/2021-09-20-github-actions-ephemeral-self-hosted-runners-new-webhooks-for-auto-scaling/).

@iii-i Looks like it works now. So, is it ready to merge?

@Dead2 Yes, I think so.

Regarding installing updates on the builder, once QEMU 6.2 is released, I will configure auto-updating https://github.com/multiarch/qemu-user-static there and send a corresponding PR.

@iii-i QEMU 6.2 has been released, and GHA emailed me that we should update our runner yesterday. Any chance of getting that updated?

I am also contacting RedHat about getting a subscription so we can get system updates on that VM.. OIC, there are warnings but it is actually bypassed

I'll send a PR with the GHA upgrade (it's strange that the runner does not receive upgrade notifications from the server, but oh well).
With QEMU, we'll have to wait for a new https://github.com/multiarch/qemu-user-static release.

@iii-i I don't think this is the reason it does not self-update for us, but the following was mentioned in the mail from Github.

Normally, self-hosted runners will auto-update during startup. When used in conjunction with the --ephemeral flag,
runner versions prior to 2.283.3 had an issue that would cause startup to fail during this auto-update process.
To ensure minimal disruption to your Actions workflows, we temporarily disabled automatic runner upgrades
for ephemeral runners 

I did not see any ephemeral flag in our config though, and I assume we would not need to use it anyway.

Ah, I see! We actually do use it. It's needed because it helps ensuring that we start with a clean slate each time.

Mystery solved 💯
The mail also says they will re-enable auto-updates in March or something, so we should be good then 👍