Merge from staging #6

- declared some properties
- merged  unset() calls

…or the joomla core Fixes #6 (#12)

* inital port to the joomla core

* add com_mailto as supported form (requires joomla#20265)

* install & update SQL & mark as core extension

* bump version to trigger drone

* new line & drone

* implement consentbox text based on the work by @brianteeman thanks!

* thanks drone

* new line

* doc block

* rename plugin to ConfirmConsent

* fix inine comments

* typo thanks @sandewt

* implement LanguageAssociations thanks @infograf768

* fix check

* move the update sql's to its own files to avoid merge conflicts

* fix postgresql file

* thanks @infograf768

* fix problems fund by @infograf768

* extend description

* implement modal support thanks @infograf768

* new text thanks @brianteeman

* drone

* add missing period

* thanks @brianteeman

* thanks @Sandra97

* remove Scalar types

* fix association

* fix comments thanks @sandewt

* class var type

* fix language string and us another namesprace

* the 2nd field is package_id

* the 2nd field is package_id

* the 2nd field is package_id

* add com_privacy.request

* Load correct core files of override files (#2)

Start implements loadcorefile() in administrator/components/com_templates/Model/TemplateModel.php

* CS (#3) Coding Standards

* codingstandards

* codingstandards (#4)

* Test (#6)

Phase 2 (2 part) Mechanism to find correct core file and implementation.

* Remove Notice: Only available for html-folder

* Remove Warning if core file not found (#11)

Thanks.
So one part of the issue joomla-projects/gsoc18_override_management#12 is done.

* Implement the diff view in template manager 

Implement the diff view in template manager

* coding standard (#17)

* fix diff (#18) Fix bug in path in case of administrator template override.

Fix bug in path in case of administrator template override.

* Notification after update and TEST (#16)

Find changed files of overridden files and show message.

* coding standard (#21)

* correction

* correction (#26)

* Correcthtmlpath (#27)

* correction

* change oldhtml to newhtml

* List of updated override files. (#30)

* addcss (#34)

* Final Product  (#39)

Core and Diff view
Updated override history list.
Quick icon notification plugin.
Override control plugin.

* save 3 lines :)

* New feature show status. (#47)

show status in com_template view templates

* link

* corrected namespace

* Button to Switch (#35)

* wip add Switcher

* wip style switcher

* wip style switch make inline and change on off text

* wip start with js

* wip js

* wip delete buttons and make js more robust

* wip save to storage

* wip delete old code

* wip

* wip lint

* wip css

* set default value for switcher

* wip make switcher blue

* wip

* wip

* build

* correct names

* create new functions

* fist test code

* use onchange

* undo installer.min.js

* add forgotten new line at the end of css file

* correct align

* correct compare.es6 - only deleted the toggle part

* correct compare.js - only deleted the toggle part

* wip

* reduce timeout

* wrap in funcitons

* wip

* add use strict to both js-files(compare and toggle)

* add the timeout value of 500 again, because 200 are not enought in my case

* use css class 'active' for toggle views

* add strict

* time out for editor

* wip

* improvments use newActive and switch

* correction

* width of switcher-spans

* correct align

* do not use global

* wip

* removed timeouts

* JTEXT to TEXT

* forgotton last line

* deleted duplicated comments

* css fix align

* use unnamed functions in es6

* Sql files for fix database (#50)

* sql files for database fix

* delete space

* Suggestion for displaying Dates in view updates files (joomla#52)

Correct Dates and do not use date of file any more

* Store Date as UTC and show it in server time zone (joomla#57)

* modified and created date are created and stored in UTC

* convert dates for displaying in model

* spar a loop

* normalize timezone in view

* use language constants for dateformat

* JToolbarHelper to ToolbarHelper

* CS

* namespace

* plural

* name

* clean

* text

* fx

* sin

* files

* s

* Suggestion for language strings (joomla#60)

* language strings

* correct typo

* delete media folder plg_quickicon

* add folder plg_quickicon to build/media_src

* delete files in media folder

* Move media folder - System (joomla#66)

* multi

* cs

* delete files in media folder for joomla toolbar (joomla#67)

* Fix button switchers style. (joomla#70)

* button

* CS

* changed uitab.addTab for updated files

* Bring back core.js changes. (joomla#69)

* core.js

* const

* fix

* form

* core

* hound

* CS

* scopr

* grid

* alpha

* cs

* lang

* only override file

* lang

* override lang installer

* Cs

* sub

* Update list of core extensions (joomla#71)

* Language changes (joomla#76)

* update

* Update en-GB.com_templates.ini

* override JLIB_HTML_PUBLISH_ITEM

this is the hover text on the publish icon in the list of files

* Change icon (joomla#74)

change the icon to use an outline for more consistency

* lang

* not core (joomla#75)

* not core

* Update en-GB.plg_installer_override.ini

* namespace

* cs

* Updated files (joomla#82)

* Update default_updated_files.php

* Update en-GB.com_templates.ini

* Update en-GB.com_templates.ini (joomla#81)

* Update en-GB.plg_quickicon_overridecheck.ini (joomla#80)

* Update en-GB.plg_quickicon_overridecheck.ini (joomla#79)

* remove space (joomla#78)

* Update en-GB.plg_quickicon_overridecheck.ini

* Update en-GB.plg_quickicon_overridecheck.sys.ini

* remove hardcoded id

* null get function

* state

* clean

* More changes "core" to "original" (joomla#85)

* cs

* update

* plural

* This is a combination of 8 commits.
This is the 1st commit message:

> First WIP version of supporting nested subforms.

This is the commit message #2:

> Fix nested subforms not getting correct name attribute on input fields.

This is the commit message #3:

> Fix subform rows having invalid index, fix small typo.

This is the commit message #4:

> Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process.

This is the commit message #5:

> Implement feedback from PR at Joomla;
> - Use a <template> HTML element for the template of the subform rows,
>   not a url encoded string inside of a <script> element.
> - Fix code style errors reported by phpcs.
> - Make the fixing of the unique attributes (name, id, etc) of input elements
>   of nested subform rows more errorprone, using the same method as the main
>   subform row.
> - Manually add a minified version of the javascript file.

This is the commit message #6:

> Fix failing javascript tests due to changed structure of subform repeatable template container.

This is the commit message #7:

> Change subform repeatable javascript test to correctly check on
> 0-indexed rows, previously they have been 1-indexed.

This is the commit message #8:

> Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly.
> Additionally added a note why the fixScripts() method is broken and how it could get better.

* Commit code styling errors and add an aria label for the outermost 'add' button.

* Fix double group-add button on repeatable subform type.

…ngle query, reduce 20, 50, 100 queries (page limit) to 1 (joomla#22117)

* Categoy manager, get all counters via single query

* Replace countItems() and countTagItems() methods with a reusuable counterRelations() method in ContentHelper class

* CS

* Since deploy version

* Better ordering for states to property names array

* Coding style (#6)

* Removed unneeded  parameter from counting methods

* CS

Joomla 3.9.0 Part #6

Metismenu frontend - wrapping UL attributes in an array