Skip to content

Fixed layout long titles + text in beez3 template#8317

Merged
wilsonge merged 1 commit intojoomla:stagingfrom
pe7er:beez-title-wordwrap
May 7, 2016
Merged

Fixed layout long titles + text in beez3 template#8317
wilsonge merged 1 commit intojoomla:stagingfrom
pe7er:beez-title-wordwrap

Conversation

@pe7er
Copy link
Copy Markdown
Contributor

@pe7er pe7er commented Nov 7, 2015

This PR fixes the layout of long article titles & text articles in the Beez3 template.
Similar problem as this PR for Protostar template: #8312

Testing Instruction

Before the PR

Create a new article

Content > Article > [New]
Use a very long title + article text that has no spaces or hyphens -
See instruction of: #8312
And set the Beez3 template as Default Template:
Extensions > Templates > select "Beez3 - Default" & set as default (or click on the star)

Front-end with Beez3 template looks weird

The front-end view of the Beez template does not break the title and text, and those both mess up the layout.

long_title_beez_before1

After the PR

I've added word-wrap: break-word; to body h1,body h2,body h3,body h4,body h5,body h6 { and body p,body ol,body ul,body dl,body address { of /templates/beez3/css/layout.css

long_title_beez_after

@waader
Copy link
Copy Markdown
Contributor

waader commented Nov 7, 2015

I have tested this item ✅ successfully on 037b0b2

Thanks pe7er!

I spotted another candidate for you in protostar > latest articles.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8317.

@pe7er
Copy link
Copy Markdown
Contributor Author

pe7er commented Nov 7, 2015

Thanks for testing @waader & for spotting the issue with latest articles.
I've created a patch for that one too: #8318

@RickR2H
Copy link
Copy Markdown
Member

RickR2H commented Dec 12, 2015

I have tested this item ✅ successfully on 037b0b2

Applied patch and test was successful

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8317.

@FeikeMulder
Copy link
Copy Markdown

FeikeMulder commented Dec 12, 2015

I have tested this item ✅ successfully on 037b0b2

Tested successfully in Beez3

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8317.

@Bakual
Copy link
Copy Markdown
Contributor

Bakual commented Dec 12, 2015

Doesn't that also break words when there would be a space within the title? From what I know word-wrap: break-word does break a word whenever it reachs the end of the line, doesn't matter if there would have been a space or not.
I don't think that is a behaviour we want. Yes, for very long titles without any spaces we would need it, but for long titles with spaces in it (which probably are far more often) it would be a very bad change.

What is the usecase where you have such a long "one-word" title? Wouldn't there be better solutions than using break-word in that case?

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Dec 13, 2015

See my comment here:
#8312 (comment)

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jan 16, 2016

Based on @Bakual comments I am setting this to Needs Review for a maintainer to make a decision

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8317.

@MDXBilal12
Copy link
Copy Markdown

MDXBilal12 commented Apr 19, 2016

I have tested this item ✅ successfully on 037b0b2

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8317.

@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented May 7, 2016

I can't find any documentation about the behaviour Thomas mentioned merging

@wilsonge wilsonge merged commit 9ccc053 into joomla:staging May 7, 2016
@wilsonge wilsonge added this to the Joomla 3.6.0 milestone May 7, 2016
@pe7er pe7er deleted the beez-title-wordwrap branch September 25, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.6.0

Development

Successfully merging this pull request may close these issues.

10 participants

@pe7er @waader @RickR2H @FeikeMulder @Bakual @infograf768 @brianteeman @MDXBilal12 @wilsonge @joomla-cms-bot