Skip to content

com_search - Fix long titles + text in search results#8334

Merged
wilsonge merged 1 commit intojoomla:stagingfrom
pe7er:com_search-title-wordwrap
May 7, 2016
Merged

com_search - Fix long titles + text in search results#8334
wilsonge merged 1 commit intojoomla:stagingfrom
pe7er:com_search-title-wordwrap

Conversation

@pe7er
Copy link
Copy Markdown
Contributor

@pe7er pe7er commented Nov 8, 2015

This PR fixes the layout for long titles and long text in the search results of com_search for both the Protostar and the Beez3 template

Testing Instructions

Create a new article with a long title and long article text as described in #8312

Before the PR

with Protostar template

On the front-end use Joomla's Search functionality and search for the article with the long title,
to see that the long title & text mess up the layout.

com_search_results-before-title-before

with Beez3 template

In the back-end change the default template to Beez3
On the front-end use Joomla's Search functionality and search for the article with the long title,
to see that the long title & text mess up the layout.

com_search_results-before-title-beez3-before

After the PR

with Protostar template

This PR should fix the layout

com_search_results-before-title-after

with Beez3 template

This PR should fix the layout

com_search_results-before-title-beez3-after

@waader
Copy link
Copy Markdown
Contributor

waader commented Nov 15, 2015

I have tested this item ✅ successfully on acb6002

Thanks pe7er!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8334.

@w13ear
Copy link
Copy Markdown

w13ear commented Dec 12, 2015

I have tested this item ✅ successfully on acb6002

I have tested this patch succesfully for both Protostar and beez3.
Added an artile with long words in header and content with the expected results.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8334.

@Bakual
Copy link
Copy Markdown
Contributor

Bakual commented Dec 12, 2015

Same comment here as in other similar PRs. What if the title is built from different words? And where do we have such long words in a title in practice?

@superknutsel
Copy link
Copy Markdown

superknutsel commented Dec 12, 2015

I have tested this item ✅ successfully on acb6002

@test tested successfully, and yes, a name this long is unlikely. But I found in practice that some customers do not use a space after a comma and therefore create a simmilar effect. Doing something like "bucket,shovel,sand,water,etc" and create the same kind of issue.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8334.

@Bakual
Copy link
Copy Markdown
Contributor

Bakual commented Dec 12, 2015

Doing something like "bucket,shovel,sand,water,etc" and create the same kind of issue.

Sounds like the proper fix is then to use a space after a coma 😄

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jan 16, 2016

Based on @Bakual comments I am setting this to Needs Review for a maintainer to make a decision

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8334.

@wilsonge wilsonge merged commit db3688f into joomla:staging May 7, 2016
@wilsonge wilsonge added this to the Joomla 3.6.0 milestone May 7, 2016
@pe7er pe7er deleted the com_search-title-wordwrap branch September 25, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.6.0

Development

Successfully merging this pull request may close these issues.

8 participants

@pe7er @waader @w13ear @Bakual @superknutsel @brianteeman @wilsonge @joomla-cms-bot