Post install messages#8457
Conversation
|
I have tested this item ✅ successfully on 30b00b9 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8457. |
|
RTC as it is a language change. Let the PLT decide to go with it. Thanks. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8457. |
|
hmm... |
There was a problem hiding this comment.
if we change it, it is not crystal clear what the "Reset Messages" button is for, wouldn't "Unread Messages" for the button better. Then it is clear.
There was a problem hiding this comment.
No because the word 'unread' has two different meanings.
It would normally mean 'show me the messages that have not been read yet'
and not 'mark the messages that have been read already as to be read'
Using the word unread to mean undo the action of reading is not real
English.
On 20 Nov 2015 9:05 am, "Robert Deutz" notifications@github.com wrote:
In administrator/language/en-GB/en-GB.com_postinstall.ini
#8457 (comment):@@ -8,7 +8,7 @@ COM_POSTINSTALL_BTN_HIDE="Hide this message"
COM_POSTINSTALL_BTN_RESET="Reset Messages"
COM_POSTINSTALL_CONFIGURATION="Post-installation Messages: Options"
COM_POSTINSTALL_LBL_MESSAGES="Post-installation and Upgrade Messages"
-COM_POSTINSTALL_LBL_NOMESSAGES_DESC="You have already seen and hidden all the messages. To display them again please select the Reset Messages button below."
+COM_POSTINSTALL_LBL_NOMESSAGES_DESC="You have read all the messages."if we change it, it is not crystal clear what the "Reset Messages" button
is for, wouldn't "Unread Messages" for the button better. Then it is clear.—
Reply to this email directly or view it on GitHub
https://github.com/joomla/joomla-cms/pull/8457/files#r45447864.
There was a problem hiding this comment.
but reset seems to me also not the right word, we don't "reset messages" we reset the read/unread state of a message
There was a problem hiding this comment.
You are thinking as a developer not as a speaker of English
On 20 Nov 2015 5:28 pm, "Robert Deutz" notifications@github.com wrote:
In administrator/language/en-GB/en-GB.com_postinstall.ini
#8457 (comment):@@ -8,7 +8,7 @@ COM_POSTINSTALL_BTN_HIDE="Hide this message"
COM_POSTINSTALL_BTN_RESET="Reset Messages"
COM_POSTINSTALL_CONFIGURATION="Post-installation Messages: Options"
COM_POSTINSTALL_LBL_MESSAGES="Post-installation and Upgrade Messages"
-COM_POSTINSTALL_LBL_NOMESSAGES_DESC="You have already seen and hidden all the messages. To display them again please select the Reset Messages button below."
+COM_POSTINSTALL_LBL_NOMESSAGES_DESC="You have read all the messages."but reset seems to me also not the right word, we don't "reset messages"
we reset the read/unread state of a message—
Reply to this email directly or view it on GitHub
https://github.com/joomla/joomla-cms/pull/8457/files#r45494426.
There was a problem hiding this comment.
So then explain me as a developer what "Reset Messages" for a speaker of English means, please.
|
I'd agree with JM. I'm not sure about this change, and would be inclined to reject it s it currently stands. I think the term "Review" is likely to be clearer if English isn't your first language (it avoids the awkward double meanings). I don't mind the extra information on the Post Installation Messages page as it is providing additional value, and is otherwise pretty empty. I would support a change to remove all the extra information on the cpanel page and just leave the title and the button (without renaming it). Whilst it may have had value when initially introduced, it's now cumbersome. Given two people questioning the change, I'm moving it back to pending as it needs additional support or changes. PLT don't need to be bothered with it yet, IMO. (PS. I'm just back for a brief stint in the JBS. I'm not prepared to spend much until I can get all the sites I maintain up to V3. Too many third party extensions won't upgrade without issues.) This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8457. |
|
Seems I've lost my ability to make status changes (or maybe never had it - it's been a while). This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8457. |
|
done you got it back @pjwiseman let me know if you need help with the new Tracker and contact me e.g. on glip welcome back 😄 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8457. |
|
I have tested this item ✅ successfully on 30b00b9 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8457. |
|
Merged, thanks everybody for participating. |
Remove extra text and change Review to Read. It really isnt necessary to have a wall of text explaining that if you click on the button immediately below called read messages then this will allow you ro read the message.