Skip to content

process: memory leaks on recursive ticking#433

Merged
yorkie merged 1 commit intomasterfrom
fix/tick
Dec 3, 2018
Merged

process: memory leaks on recursive ticking#433
yorkie merged 1 commit intomasterfrom
fix/tick

Conversation

@legendecas
Copy link
Copy Markdown
Contributor

@legendecas legendecas commented Dec 3, 2018 •
edited
Loading

Checklist

close #432

  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added

Before

process/next_tick_create.js
process/next_tick_create.js n=1024: 26,698.986345867223

process/next_tick_create_5.js
process/next_tick_create_5.js n=1024: 27,663.1749112293

process/next_tick_parallel.js
process/next_tick_parallel.js n=1024: 18,206.212308117814

process/next_tick_parallel_5.js
process/next_tick_parallel_5.js n=1024: 12,624.287590739534

process/next_tick_recursive.js
process/next_tick_recursive.js n=1024: 52,327.725272901356

process/next_tick_recursive_5.js
process/next_tick_recursive_5.js n=1024: 20,872.33860102376

After

process/next_tick_create.js
process/next_tick_create.js n=1024: 25,598.715584445552

process/next_tick_create_5.js
process/next_tick_create_5.js n=1024: 22,949.062561049494

process/next_tick_parallel.js
process/next_tick_parallel.js n=1024: 19,085.975254473924

process/next_tick_parallel_5.js
process/next_tick_parallel_5.js n=1024: 12,053.820023895287

process/next_tick_recursive.js
process/next_tick_recursive.js n=1024: 39,437.52537539017

process/next_tick_recursive_5.js
process/next_tick_recursive_5.js n=1024: 19,145.06192857295
case delta
next_tick_create 1.04
next_tick_create_5 1.2
next_tick_parallel 0.95
next_tick_parallel_5 1.04
next_tick_recursive 1.32
next_tick_recursive_5 1.09
over all 1.11

@legendecas legendecas requested review from qile222 and yorkie December 3, 2018 13:55
yorkie
yorkie approved these changes Dec 3, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorkie yorkie merged commit 5c26750 into master Dec 3, 2018
@yorkie yorkie deleted the fix/tick branch December 3, 2018 14:53
qile222 pushed a commit that referenced this pull request Dec 13, 2018
Merge branch 'master' into feature/array-routine
46d8fd8 
* master: (35 commits)
  https: client request doesn’t define default encoding (#440)
  n-api: data pointer was NULL on getting typed array info (#441)
  os: build bcast address interface. (#439)
  assert: better deepStrictEqual assertion (#435)
  working on v0.11.x (#434)
  process: memory leaks on recursive ticking (#433)
  uv, os: implement os.{get,set}Priority functions (#409)
  jerry: implement ES2015 class feature (part II.) (#428)
  test: fix wrong travis diff target introduced by #425 (#429)
  jerry: pass and enable jerry-test-suite (#425)
  n-api: ArrayBuffer/TypedArray support (#419)
  deps: upgrade the mbedtls to 2.13.0-apache (#384)
  jerry: rework jerry_parse function (#422)
  jerry: finalize hint of array buffers (#421)
  jerry: reduce the argument count of ecma_op_object_get_property_names (#424)
  n-api: update headers/test suites to LTS(10.13.0) (#416)
  jerry: Date.now shall return an integer (#418)
  n-api: thread safe functions (#411)
  util: IOTJS_ASSERT prints stack trace on macOS (#415)
  process: set immediate shall start an idle handle to activate uv_loop (#417)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yorkie yorkie yorkie approved these changes

@qile222 qile222 qile222 approved these changes

Assignees

No one assigned

Labels

perf process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

next-tick: memory leaks on recursive ticking

3 participants

@legendecas @yorkie @qile222