Skip to content

jerry: implement ES2015 class feature (part II.)#428

Merged
yorkie merged 13 commits intomasterfrom
jerry/class
Nov 30, 2018
Merged

jerry: implement ES2015 class feature (part II.)#428
yorkie merged 13 commits intomasterfrom
jerry/class

Conversation

@legendecas
Copy link
Copy Markdown
Contributor

@legendecas legendecas commented Nov 29, 2018

Currently Working On
  • Unexpected error on super call:
    ICE: Assertion 'frame_ctx_p->registers_p + register_end + frame_ctx_p->context_depth == stack_top_p' failed at /Users/lucas/Developer/github/ShadowNode/deps/jerry/jerry-core/vm/vm.c(vm_loop):2925.
Checklist
  • npm test passes

@legendecas legendecas changed the title jerry: computed properties for object literals jerry: implement ES2015 class feature (part II.) Nov 29, 2018
@legendecas legendecas added the work-in-progress This PR is working in progress. label Nov 29, 2018
@legendecas legendecas removed the work-in-progress This PR is working in progress. label Nov 30, 2018
@yorkie yorkie added the minor minor changes label Nov 30, 2018
Copy link
Copy Markdown
Member

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorkie
Copy link
Copy Markdown
Member

yorkie commented Nov 30, 2018

BTW, @legendecas could you please reference the upstream PRs that you picked?

@legendecas
Copy link
Copy Markdown
Contributor Author

BTW, @legendecas could you please reference the upstream PRs that you picked?

I've referenced upstream PR in every single commit in its commit message.

@yorkie yorkie merged commit 3c4bb93 into master Nov 30, 2018
@yorkie yorkie deleted the jerry/class branch November 30, 2018 14:19
qile222 pushed a commit that referenced this pull request Dec 13, 2018
* master: (35 commits)
  https: client request doesn’t define default encoding (#440)
  n-api: data pointer was NULL on getting typed array info (#441)
  os: build bcast address interface. (#439)
  assert: better deepStrictEqual assertion (#435)
  working on v0.11.x (#434)
  process: memory leaks on recursive ticking (#433)
  uv, os: implement os.{get,set}Priority functions (#409)
  jerry: implement ES2015 class feature (part II.) (#428)
  test: fix wrong travis diff target introduced by #425 (#429)
  jerry: pass and enable jerry-test-suite (#425)
  n-api: ArrayBuffer/TypedArray support (#419)
  deps: upgrade the mbedtls to 2.13.0-apache (#384)
  jerry: rework jerry_parse function (#422)
  jerry: finalize hint of array buffers (#421)
  jerry: reduce the argument count of ecma_op_object_get_property_names (#424)
  n-api: update headers/test suites to LTS(10.13.0) (#416)
  jerry: Date.now shall return an integer (#418)
  n-api: thread safe functions (#411)
  util: IOTJS_ASSERT prints stack trace on macOS (#415)
  process: set immediate shall start an idle handle to activate uv_loop (#417)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jerry minor minor changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants