Skip to content

jerry: reduce the argument count of ecma_op_object_get_property_names#424

Merged
yorkie merged 1 commit intomasterfrom
jerry/properties
Nov 26, 2018
Merged

jerry: reduce the argument count of ecma_op_object_get_property_names#424
yorkie merged 1 commit intomasterfrom
jerry/properties

Conversation

@legendecas
Copy link
Copy Markdown
Contributor

@legendecas legendecas commented Nov 26, 2018

Picked from upstream jerryscript-project/jerryscript#2598

A pre-requirement to Symbol implementation. Which simplifies future support of Object.getOwnPropertySymbols.

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added (No API has changed)

Copy link
Copy Markdown
Member

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, hard work 👍

@yorkie yorkie merged commit c902cbc into master Nov 26, 2018
@yorkie yorkie deleted the jerry/properties branch November 26, 2018 13:55
qile222 pushed a commit that referenced this pull request Dec 13, 2018
* master: (35 commits)
  https: client request doesn’t define default encoding (#440)
  n-api: data pointer was NULL on getting typed array info (#441)
  os: build bcast address interface. (#439)
  assert: better deepStrictEqual assertion (#435)
  working on v0.11.x (#434)
  process: memory leaks on recursive ticking (#433)
  uv, os: implement os.{get,set}Priority functions (#409)
  jerry: implement ES2015 class feature (part II.) (#428)
  test: fix wrong travis diff target introduced by #425 (#429)
  jerry: pass and enable jerry-test-suite (#425)
  n-api: ArrayBuffer/TypedArray support (#419)
  deps: upgrade the mbedtls to 2.13.0-apache (#384)
  jerry: rework jerry_parse function (#422)
  jerry: finalize hint of array buffers (#421)
  jerry: reduce the argument count of ecma_op_object_get_property_names (#424)
  n-api: update headers/test suites to LTS(10.13.0) (#416)
  jerry: Date.now shall return an integer (#418)
  n-api: thread safe functions (#411)
  util: IOTJS_ASSERT prints stack trace on macOS (#415)
  process: set immediate shall start an idle handle to activate uv_loop (#417)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants