Merged
Conversation
Member
|
Let's remove the ugly prefix |
2007155 to
66d8871
Compare
66d8871 to
ce76c9e
Compare
yorkie
requested changes
Nov 20, 2018
Member
yorkie
left a comment
There was a problem hiding this comment.
This looks like our first land on the N-API experimental functions, it's cool anyway, so I think the aspect of documenting should be reverse from the non-experimental, namely explicitly document experimental functions.
| @@ -0,0 +1,208 @@ | |||
| 'use strict'; | |||
Member
There was a problem hiding this comment.
Are this file a copy from https://github.com/Rokid/ShadowNode/blob/master/test/addons-napi/test_threadsafe_function/test.js? If yes, suggest that open an issue on nodejs/napi-test-suite to track how should we address this with N-API team.
1e54d89 to
7d62845
Compare
yorkie
approved these changes
Nov 20, 2018
qile222
pushed a commit
that referenced
this pull request
Dec 13, 2018
* master: (35 commits) https: client request doesn’t define default encoding (#440) n-api: data pointer was NULL on getting typed array info (#441) os: build bcast address interface. (#439) assert: better deepStrictEqual assertion (#435) working on v0.11.x (#434) process: memory leaks on recursive ticking (#433) uv, os: implement os.{get,set}Priority functions (#409) jerry: implement ES2015 class feature (part II.) (#428) test: fix wrong travis diff target introduced by #425 (#429) jerry: pass and enable jerry-test-suite (#425) n-api: ArrayBuffer/TypedArray support (#419) deps: upgrade the mbedtls to 2.13.0-apache (#384) jerry: rework jerry_parse function (#422) jerry: finalize hint of array buffers (#421) jerry: reduce the argument count of ecma_op_object_get_property_names (#424) n-api: update headers/test suites to LTS(10.13.0) (#416) jerry: Date.now shall return an integer (#418) n-api: thread safe functions (#411) util: IOTJS_ASSERT prints stack trace on macOS (#415) process: set immediate shall start an idle handle to activate uv_loop (#417) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm testpassesUnit tests depends on #406.
Introduce thread safe functions into N-API. Simplify complex native add-ons to notify JavaScripts in a work thread without blocking work thread nor main thread.