Skip to content

Adds Gluecode to present notices from the Android app#2697

Merged
antonis merged 3 commits intodevelopfrom
issue/2453-ShowNoticeAndroid
Oct 12, 2020
Merged

Adds Gluecode to present notices from the Android app#2697
antonis merged 3 commits intodevelopfrom
issue/2453-ShowNoticeAndroid

Conversation

@antonis
Copy link
Copy Markdown

@antonis antonis commented Oct 8, 2020

Fixes: #2453

Related PRs:
gutenberg WordPress/gutenberg#25951
WordPress-Android wordpress-mobile/WordPress-Android#13085

To test:

Layout Picker should show when creating a new page from My Site or Site Pages the Modal Layout Picker appears.

  • Start by navigating to the Modal Layout Picker

Page Created (with content)

  1. Select a Layout from the options in Modal Layout Picker
  2. Select "Create Page"
    Expect to see the info notice banner appear under the navigation bar with the text "Page created"
  • 🗒️ This is different than the mocks in the linked issue but aligns with the direction that was determined.

Blank Page Created

  1. Select "Create Blank Page"
    Expect to see the info notice banner appear under the navigation bar with the text "Blank page created"
  • 🗒️ This is different than the mocks in the linked issue but aligns with the direction that was determined.

Blog Post Created

  1. Create a new blog post
  • This should not display the notice bar

Open existing Page Created

  1. Open an existing page (either published or draft)
  • This should not display the notice bar

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Oct 9, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@antonis antonis requested a review from Tug October 12, 2020 06:47
@antonis
Copy link
Copy Markdown
Author

antonis commented Oct 12, 2020

Hello @Tug 👋 ,
This PR includes only the reference update for the gutenberg pr WordPress/gutenberg#25951

Copy link
Copy Markdown
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antonis antonis merged commit d65d167 into develop Oct 12, 2020
@antonis antonis deleted the issue/2453-ShowNoticeAndroid branch October 12, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants