You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Generated by 🚫 dangerJS

You can test the changes on this Pull Request by downloading the APK here.

After the Consolidation of the Gutenberg initialProps handling a refactoring is needed in the way the MLP configuration is passed

Hello @iamthomasbishop 👋 ,

I've completed a first version of the MLP container. Please let me know if you have any design feedback on the attached screenshots or the the APK here.
I tried to use the existing text styles of the App. Please provide more information on this to fully align with the provided designs.
Thank you in advance :)

This has been updated with the Consolidation of the Gutenberg initialProps handling and should not be merged till gutenberg/after_release_1.33.0 is merged

👋 @antonis ! I think if you retarget this PR to the gutenberg/after_release_1.33.0 branch that would both make the diff on this PR a lot smaller and it would allow you to merge this PR before gutenberg/after_release_1.33.0 gets merged to develop. If you did that and gutenberg/after_release_1.33.0 got merged before this PR was merged you could just retarget it back to develop again (I think Github actually might do that for you automatically when the branch you are targeting gets merged). This certainly isn't critical, it's just a suggestion.

I think if you retarget this PR to the gutenberg/after_release_1.33.0 branch that would both make the diff on this PR a lot smaller and it would allow you to merge this PR before gutenberg/after_release_1.33.0 gets merged to develop.

That sound good. I made the change.
Thank you for the prompt feedback @mchowning :)

Hey @antonis 👋 Took the build for a spin, and it's coming along nicely. Not seeing any big issues, but here are my notes.

Sheet surface

I'm not sure if this is intentional or not, but I noticed when you're scrolled to the top of the view and pull down softly, we have a snap point where the sheet gets docked at ~2/3 height (video example). We probably only need 2 heights — full-screen and closed.

I'm not sure if this something we can control, but when you scroll to the bottom of the sheet and get the usual "ripple" effect (the blue "wave" that shows when you scroll to the end of a container), there looks to be a ~16dp gap between that and the top edge of the footer bar. (video example)

Collapsed app bar style

The text label on the app bar when it's in a collapsed state doesn't look centered. (screenshot)

Title/subtitle

The sizing of the title and subtitle look a little small — I believe the title should be set in Headline 4 and the subtitle in Body 1, but it's hard to tell what the current values are in this build — would you mind confirming?

Is there any way we can use the system-default serif font (Noto Serif)? My original mockups used the bold weight because that's what we were leaning towards using for headlines across the app, but I'll have to check in to see if that's the final decision.

The spacing between the app bar and title also look a little tight — can you confirm how much space is between these (I believe it should be 16, although IIRC the line-height of the labels might be slightly different, which would result in a slight diff)?

The spacing between the title and subtitle look a bit too much, but this might be an optical illusion bc of the too-small spacing mentioned above (this also should be 16).

Status bar color

Would it be possible to adapt the status bar to a light variation (white background, dark text) when the sheet is fully open? For reference, we're also using this style on post/page preview.

@antonis an update regarding my comment on font-weight of the headings:

Is there any way we can use the system-default serif font (Noto Serif)? My original mockups used the bold weight because that's what we were leaning towards using for headlines across the app, but I'll have to check in to see if that's the final decision.

We are using the bold weight of Noto Serif for headings as I thought, so we can use that for this sheet 😄

Hello @ashiagr 👋 ,
thank you for your feedback. I really appreciate it :)

On your observations:

• On transitioning from landscape to portrait, title was not displayed until I significantly scrolled down (it didn't happen consistently - just once in a while). Let me know if it is an expected behaviour.

I reproduced this behavior and fixed this.

• Wondering if we could use CollapsingToolbarLayout inside a bottom sheet for a smoother title transitioning. Let me know if you already considered it or encountered any challenges. Here's a related SO discussion.

I agree with you on this. An implementation based on CoordinatorLayout and CollapsingToolbarLayout would be much simpler and cleaner. When I started the implementation I tried this direction but it proved tricky inside the BottomSheetDialogFragment. I spend again a few hours on this today since the SO link was quite helpful but I got to a point where I got inconsistent behavior since the BottomSheetDialogFragment combined with the nested (part of a next PR) RecyclerViews make this quite complex. I decided that at this point it might be better to proceed with the current solution and revisit this in a next PR as an optimisation effort. Wdyt?

I reproduced this behavior and fixed this.

Thanks, I confirm it is fixed now 🎉.

at this point it might be better to proceed with the current solution and revisit this in a next PR as an optimisation effort. Wdyt?

Thanks for giving it a try 🙇‍♀️. I agree with your suggestion, let's proceed with the current solution. Using CollapsingToolbarLayout might not a be a straightforward solution. Whenever (and if) you decide to retry let me know. I'll be happy to pair on this any time after approx. two weeks.

A new build time configuration MODAL_LAYOUT_PICKER enables this feature.
At this point it is only enabled in wasabi and jalapeno flavors and won't affect alpha, beta and release build