[Modal Layout Picker] Show toast messages after creating a new page#13085
Merged
[Modal Layout Picker] Show toast messages after creating a new page#13085
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
This was referenced Oct 8, 2020
|
You can test the changes on this Pull Request by downloading the APK here. |
# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/main/WPMainActivity.java # WordPress/src/main/java/org/wordpress/android/ui/pages/PagesFragment.kt # WordPress/src/main/java/org/wordpress/android/viewmodel/mlp/ModalLayoutPickerViewModel.kt # build.gradle
# Conflicts: # libs/gutenberg-mobile
3 tasks
# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/mlp/ModalLayoutPickerFragment.kt # WordPress/src/main/java/org/wordpress/android/viewmodel/mlp/ModalLayoutPickerViewModel.kt # build.gradle
malinajirka
reviewed
Oct 16, 2020
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @antonis! I haven't tested the app (except of one specific scenario), since TUG has already tested it. I found one potential issue, let me know what you think.
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/gutenberg-mobile#2453
Related PRs:
Depends on: #13077
gutenberg-mobilewordpress-mobile/gutenberg-mobile#2697gutenbergWordPress/gutenberg#25951To test:
Layout Picker should show when creating a new page from My Site or Site Pages the Modal Layout Picker appears.
Page Created (with content)
Expect to see the info notice banner appear under the navigation bar with the text "Page created"
Blank Page Created
Expect to see the info notice banner appear under the navigation bar with the text "Blank page created"
Blog Post Created
Open existing Page Created
Screenshots
PR submission checklist:
RELEASE-NOTES.txtif necessary.