[Dependency Updates] Remove Unused Dependencies for WordPress Module#17620
Merged
[Dependency Updates] Remove Unused Dependencies for WordPress Module#17620
Conversation
Also, an associated 'compose' related comment was added for future reference. For more info see: https://developer.android.com/jetpack/compose/tooling
This was also done in order to split the 'compose' and 'stetho' dependency groups to make those more explicit.
Since 'lifecycle' and 'lifecycle-viewmodel-compose' are separate artifacts with separate versions, it is better to split those and make their versioning more explicit. For more info see: https://developer.android.com/jetpack/androidx/ releases/lifecycle
Since 'compose' and 'compose-compiler' have now using independent versioning it is recommended to split those and make their versioning more explicit. For more info see: https://android-developers.googleblog.com/2022/06/ independent-versioning-of-Jetpack-Compose-libraries.html
It is generally recommended that transitively used dependencies that should be declared directly.
The grouping follows the below logic: 1. First, add the 'runtime' related dependencies. 2. Then, add the 'foundation' related dependencies. 3. Then, add the 'ui' related dependencies. 4. Finally, add any 'other' compose related dependencies, 'AndroidX' or otherwise.
It is generally recommended that transitively used dependencies that should be declared directly.
These dependencies were added as part the migration process to 'AndroidX' for this module back in Jun 2019 (b7ac12d). The only 'androidx.legacy' usage is located within the 'zs_activity_request_list_scene_empty.xml' layout file and more specifically on its 2 x 'Widget Space' elements within. This layout file was copy-pasted for Zendesk purposes back in Dec 2021 (998464e). But, this 'com.zendesk' dependency, as well as other dependencies, already contain such 'androidx.legacy' dependencies within. As such, those are anyway resolved successfully without the need to explicitly declare them. As such, this leftover from back then can be now safely removed.
This dependency seems that was lastly used only for some stats related classes that are no longer existing, like the 'StatsVisitorsAndViewsFragment' via teh 'com.jjoe64.graphview' import. However, as part of the #10282 PR, all those stats related classes got removed (see da7d52f). As such, this leftover from back then can be now safely removed. PS: Also, as part of this change the 'GraphView' dependency, and in general, the complete list of 'LGPL v3' licensed dependencies is now removed from the 'licenses.html' document for both, the WordPress and Jetpack apps.
This dependency was added as part of updating the 'Support Libraries' of this module back in Feb 2019 (8f9d6b4). However, this dependency is unused and no related import found in this project. As such, this leftover from back then can be now safely removed.
This dependency seems that was lastly used only for the no longer existing 'TenorProviderTest' test class (see 47ac89a), which was added as part of this #11587 PR. However, as part of this #14727 PR, this 'TenorProviderTest' test class got removed (see f29f6d0). As such, this leftover from back then can be now safely removed. PS: And with this change, the corresponding 'androidxTestCoreVersion' version is no longer necessary for unit test. As such, it is being moved from the more inclusive 'test' section to the more specific 'android test' section.
Contributor
|
Found 1 violations: The PR caused the following dependency changes:++--- org.greenrobot:eventbus-java:3.3.1
++--- androidx.compose.runtime:runtime:1.1.1 (*)
++--- androidx.compose.foundation:foundation-layout:1.1.1 (*)
++--- androidx.compose.ui:ui-graphics:1.1.1 (*)
++--- androidx.compose.ui:ui-text:1.1.1 (*)
+\--- androidx.compose.ui:ui-unit:1.1.1 (*)
-+--- org.wordpress:graphview:3.4.0
-+--- org.wordpress:emailchecker2:1.1.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.0.1-2 -> 1.6.10 (*)
-+--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
-+--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-\--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.3 (*)
Please review and act accordingly
|
This was referenced Dec 5, 2022
Contributor
|
|||||||||||
| 💡 Scan this QR code with your Android phone to download and install the APK directly on it. | ||
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 1791215 | |
9 tasks
Contributor
|
|||||||||||
| 💡 Scan this QR code with your Android phone to download and install the APK directly on it. | ||
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 1791215 | |
5 tasks
oguzkocer
approved these changes
Dec 5, 2022
Contributor
Author
|
Thank you for reviewing and testing this PR @oguzkocer , you rock! 🙇 ❤️ 🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Parent #17558
Partially Closes: #17555
This issue is about removing all unused dependencies for the the
WordPressrelated module.I recommend during a commit-by-commit review. You will also find additional information on the individual changes by reading a commit's description.
Compose Dependencies List:
Libs Dependencies List:
Main Dependencies List:
Test Dependencies List:
Refactor List:
@oguzkocer I added you alone as the reviewer of this change as this will help us progress with the dependency updates, in terms of making the list of dependencies that we need to update more straightforward for us. The other such PR was the #17605.
To test:
Regression Notes
Some of the dependencies removed might still be required as they might be hidden transitive dependencies and thus either crashing the app or causing some kind of misbehaviour.
See
To testsection.N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.