Issue/7166 remove legacy signup#7195
Conversation
| <category android:name="android.intent.category.DEFAULT" /> | ||
| <category android:name="android.intent.category.BROWSABLE" /> | ||
| <data | ||
| android:host="signin" |
There was a problem hiding this comment.
As @maxme has suggested over Slack, let's check with our #helpshift friends whether they need/use this shortcut to have people logged in. WDYT?
There was a problem hiding this comment.
I checked with #helpshift and it doesn't seem to be used so we can remove it.
| } | ||
|
|
||
| public static boolean isLoginWizardStyleActivated() { | ||
| return BuildConfig.LOGIN_WIZARD_STYLE_ACTIVE || getBoolean(UndeletablePrefKey.LOGIN_WIZARD_STYLE_ACTIVE, false); |
There was a problem hiding this comment.
Can we remove UndeletablePrefKey.LOGIN_WIZARD_STYLE_ACTIVE as well perhaps?
There was a problem hiding this comment.
Yes, we can. I removed the preference key in 5e8d7b3.
| // no account, load new account view | ||
| Intent i = new Intent(AddQuickPressShortcutActivity.this, SignInActivity.class); | ||
| startActivityForResult(i, ADD_ACCOUNT_REQUEST); | ||
| ActivityLauncher.showSignInForResult(AddQuickPressShortcutActivity.this); |
There was a problem hiding this comment.
ActivityLauncher.showSignInForResult uses RequestCodes.ADD_ACCOUNT as a request code but AddQuickPressShortcutActivity.java expects ADD_ACCOUNT_REQUEST in its onActivityResult. Will this still work?
There was a problem hiding this comment.
I don't think so. Good catch! I updated the request code in 46c88c1.
|
LGTM! |
Remove legacy signup code that has been superseded by the new signup flow as described in #7166.