[Dependency Updates] Remove Unused Dependencies for Libs Modules by ParaskP7 · Pull Request #17605 · wordpress-mobile/WordPress-Android

ParaskP7 · 2022-12-02T15:01:58Z

Parent #17558
Partially Closes: #17555

This issue is about removing all unused dependencies for the the libs related modules.

I recommend during a commit-by-commit review. You will also find additional information on the individual changes by reading a commit's description.

Mocks Module List:

Image Editor Module List:

Editor Module List:

Refactor List:

@oguzkocer I added you alone as the reviewer of this change as this will help us progress with the dependency updates, in terms of making the list of dependencies that we need to update more straightforward for us. Please expect another such PR that focuses solely on the WordPress module. I should have this ready on Monday... 🤞

To test:

There is nothing much to test here.
Verifying that all the CI checks are successful should be enough.
However, if you want to be thorough about reviewing this change, you could:
1. See the dependency tree diff result and verify correctness.
2. Quickly smoke test both, the WordPress and Jetpack apps, and see if they both work as expected.
3. Focus on testing the Image Editor and Editor related functionalities as this is were the bulk of the changes applied.

Regression Notes

Potential unintended areas of impact

Some of the dependencies removed might still be required as they might be hidden transitive dependencies and thus either crashing the app or causing some kind of misbehaviour.

What I did to test those areas of impact (or what existing automated tests I relied on)

See To test section.

What automated tests I added (or what prevented me from doing so)

N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

This 'apacheHttpClientAndroidVersion' is soley connected to the WireMock configuration, which is 'Android Test' related only.

Since the 'apacheHttpClientAndroidVersion' is solely connected to the WireMock configuration, it is better if it is renamed accordingly to make this more explicit going forward.

The 'androidx.lifecycle:lifecycle-livedata-ktx' dependency is unused. The 'androidx.lifecycle:lifecycle-livedata-core' is the one actually used, and that should be declared directly instead.

The 'androidx.lifecycle:lifecycle-viewmodel-ktx' dependency is unused. The 'androidx.lifecycle:lifecycle-viewmodel' is the one actually used, and that should be declared directly instead.

The 'androidx.navigation:navigation-ui-ktx' dependency is unused. The 'androidx.navigation:navigation-ui' is the one actually used, and that should be declared directly instead. In addition to that, the 'stories' module related such 'androidx.navigation:navigation-ui-ktx' dependency was excluded. Otherwise, the below 'CheckDuplicatesRunnable' error occurred: ------------------------------------------------------------------------ * What went wrong: Execution failed for task ':WordPress:checkWordpressWasabiDebugDuplicateClasses'. > A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable > Duplicate class androidx.navigation.ui.ActivityKt found in modules navigation-ui-2.4.2-runtime (androidx.navigation:navigation-ui:2.4.2) and navigation-ui-ktx-2.0.0-runtime (androidx.navigation:navigation-ui-ktx:2.0.0) ... ------------------------------------------------------------------------

The 'androidx.navigation:navigation-fragment-ktx' dependency is unused. The 'androidx.navigation:navigation-fragment' is the one actually used, and that should be declared directly instead. In addition to that, the 'stories' module related such 'androidx.navigation:navigation-fragment-ktx' dependency was excluded. Otherwise, the below 'CheckDuplicatesRunnable' error occurred: ------------------------------------------------------------------------ * What went wrong: Execution failed for task ':WordPress:checkWordpressWasabiDebugDuplicateClasses'. > A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable > Duplicate class androidx.navigation.fragment.FragmentKt found in modules navigation-fragment-2.4.2-runtime (androidx.navigation:navigation-fragment:2.4.2) and navigation-fragment-ktx-2.0.0-runtime (androidx.navigation:navigation-fragment-ktx:2.0.0) ... ------------------------------------------------------------------------

This plugin was added as part of adding 'Dagger' to this module back in Jan 2020 (0e98676). However, 'Dagger' was removed right after (af5488a). During this 'Dagger' removal, this plugin should have been removed as well, but it wasn't. As such, this leftover from back then can be now safely removed.

This dependency was added as part of updating the 'Support Libraries' of this module back in Feb 2019 (8f9d6b4). However, this dependency is unused and 'GridLayoutManager' is the only such related import found in this project. In addition to that, this is specific to the 'RecyclerView' dependency and also found only on the 'WordPress' module. As such, this leftover from back then can be now safely removed.

There is no reason for the 'androidXLegacyVersion' to be split into two separate versions as both are pointing to the same 'Legacy' release. Actually this can end up creating problems if one dependency is updated and not the other. As such, this commit merges them into one version. Legacy Release Notes: https://developer.android.com/jetpack/androidx/ releases/legacy

This dependency was added as part the migration process to 'AndroidX' for this module back in Jun 2019 (b7ac12d). However, this dependency is unused and 'Widget Space' is the only such related usage found in this project. In addition to that, this is specific to the 'Legacy Support Core UI' dependency and only found on the 'WordPress' module. As such, this leftover from back then can be now safely removed.

This dependency was added as part of updating the 'Support Libraries' of this module back in Feb 2019 (8f9d6b4). However, this dependency is unused and 'VectorDrawableCompat' is the only such related import found in this project. In addition to that, this is specific to the 'VectorDrawable' dependency, non related to 'Animated', and also found only on the 'WordPress' module. As such, this leftover from back then can be now safely removed.

This dependency was added as part of switching to latest 'Aztec' build that wasn't passing on internal dependencies to this module back in Aug 2017 (affc11f). However, this dependency is unused and 'Jsoup', 'Document' and 'Element' is the only such related imports found in this project. In addition to that, this is specific to the 'WordPress' module. It also seems that there is no longer such a requirement for those extra Aztec dependencies as they seems to be included with the library and not being stripped out, by Jitpack or otherwise. See related comment below, which was included on top of the dependency that got deleted. "Required Aztec dependencies (they should be included but Jitpack seems to be stripping these out)" As such, this leftover from back then can be now safely removed.

There is no reason for the 'androidxTestEspressoVersion' to be split into two separate versions, the 'accessibility' related version to be using an older '3.3.0-alpha05' version, while only 'main' one to be using the more stable '3.4.0' version. Both should be point to the same and newer version of the 'Espresso' library. As such, this commit merges them into one version. Espresso Release Notes: https://developer.android.com/jetpack/androidx/ releases/test Espresso Repository: https://maven.google.com/web/index.html ?q=espresso#androidx.test.espresso:espresso-accessibility

Also, the associated 'accessibility' related comment was removed as self-explanatory.

wpmobilebot · 2022-12-02T15:10:31Z

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:image-editor
+|    +--- androidx.navigation:navigation-fragment:2.4.2
+|    |    +--- androidx.fragment:fragment-ktx:1.4.1
+|    |    |    +--- androidx.fragment:fragment:1.4.1 (*)
+|    |    |    +--- androidx.activity:activity-ktx:1.2.3 -> 1.3.1
+|    |    |    |    +--- androidx.activity:activity:1.3.1 (*)
+|    |    |    |    +--- androidx.core:core-ktx:1.1.0 -> 1.7.0 (*)
+|    |    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 -> 2.4.1
+|    |    |    |    |    +--- androidx.lifecycle:lifecycle-runtime:2.4.1 (*)
+|    |    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
+|    |    |    |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.0 -> 1.5.2
+|    |    |    |    |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2
+|    |    |    |    |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.5.2
+|    |    |    |    |    |    |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.6.10 (*)
+|    |    |    |    |    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.5.30 -> 1.6.10
+|    |    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.6.10 (*)
+|    |    |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.1
+|    |    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.4.1 (*)
+|    |    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
+|    |    |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.0 -> 1.5.2 (*)
+|    |    |    |    +--- androidx.savedstate:savedstate-ktx:1.1.0
+|    |    |    |    |    +--- androidx.savedstate:savedstate:1.1.0 (*)
+|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.10 (*)
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.6.10 (*)
+|    |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.7.0 (*)
+|    |    |    +--- androidx.collection:collection-ktx:1.1.0
+|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.6.10 (*)
+|    |    |    |    \--- androidx.collection:collection:1.1.0 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.3.1 -> 2.4.1
+|    |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.4.1 (*)
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.1 (*)
+|    |    |    +--- androidx.savedstate:savedstate-ktx:1.1.0 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.10 (*)
+|    |    +--- androidx.navigation:navigation-runtime:2.4.2
+|    |    |    +--- androidx.navigation:navigation-common:2.4.2
+|    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|    |    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 -> 2.4.1 (*)
+|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.1 (*)
+|    |    |    |    +--- androidx.savedstate:savedstate:1.0.0 -> 1.1.0 (*)
+|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 (*)
+|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.10 (*)
+|    |    |    |    +--- androidx.core:core-ktx:1.1.0 -> 1.7.0 (*)
+|    |    |    |    \--- androidx.collection:collection-ktx:1.1.0 (*)
+|    |    |    +--- androidx.activity:activity-ktx:1.2.3 -> 1.3.1 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 -> 2.4.1 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.1 (*)
+|    |    |    +--- androidx.annotation:annotation-experimental:1.1.0
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.10 (*)
+|    |    +--- androidx.slidingpanelayout:slidingpanelayout:1.2.0
+|    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|    |    |    +--- androidx.customview:customview:1.1.0 (*)
+|    |    |    +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|    |    |    +--- androidx.window:window:1.0.0
+|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.10 (*)
+|    |    |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
+|    |    |    |    +--- androidx.annotation:annotation:1.2.0
+|    |    |    |    +--- androidx.collection:collection:1.1.0 (*)
+|    |    |    |    \--- androidx.core:core:1.3.2 -> 1.7.0 (*)
+|    |    |    \--- androidx.transition:transition:1.4.1 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.10 (*)
-|    +--- androidx.navigation:navigation-fragment-ktx:2.4.2
-|    |    +--- androidx.navigation:navigation-fragment:2.4.2
-|    |    |    +--- androidx.fragment:fragment-ktx:1.4.1
-|    |    |    |    +--- androidx.fragment:fragment:1.4.1 (*)
-|    |    |    |    +--- androidx.activity:activity-ktx:1.2.3 -> 1.3.1
-|    |    |    |    |    +--- androidx.activity:activity:1.3.1 (*)
-|    |    |    |    |    +--- androidx.core:core-ktx:1.1.0 -> 1.7.0 (*)
-|    |    |    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 -> 2.4.1
-|    |    |    |    |    |    +--- androidx.lifecycle:lifecycle-runtime:2.4.1 (*)
-|    |    |    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
-|    |    |    |    |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.0 -> 1.5.2
-|    |    |    |    |    |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.2
-|    |    |    |    |    |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.5.2
-|    |    |    |    |    |    |    |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.6.10 (*)
-|    |    |    |    |    |    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.5.30 -> 1.6.10
-|    |    |    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.6.10 (*)
-|    |    |    |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-|    |    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.1
-|    |    |    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.4.1 (*)
-|    |    |    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
-|    |    |    |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.0 -> 1.5.2 (*)
-|    |    |    |    |    +--- androidx.savedstate:savedstate-ktx:1.1.0
-|    |    |    |    |    |    +--- androidx.savedstate:savedstate:1.1.0 (*)
-|    |    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.10 (*)
-|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.6.10 (*)
-|    |    |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.7.0 (*)
-|    |    |    |    +--- androidx.collection:collection-ktx:1.1.0
-|    |    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.6.10 (*)
-|    |    |    |    |    \--- androidx.collection:collection:1.1.0 (*)
-|    |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.3.1 -> 2.4.1
-|    |    |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.4.1 (*)
-|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
-|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.1 (*)
-|    |    |    |    +--- androidx.savedstate:savedstate-ktx:1.1.0 (*)
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.10 (*)
-|    |    |    +--- androidx.navigation:navigation-runtime:2.4.2
-|    |    |    |    +--- androidx.navigation:navigation-common:2.4.2
-|    |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|    |    |    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 -> 2.4.1 (*)
-|    |    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.1 (*)
-|    |    |    |    |    +--- androidx.savedstate:savedstate:1.0.0 -> 1.1.0 (*)
-|    |    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 (*)
-|    |    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.10 (*)
-|    |    |    |    |    +--- androidx.core:core-ktx:1.1.0 -> 1.7.0 (*)
-|    |    |    |    |    \--- androidx.collection:collection-ktx:1.1.0 (*)
-|    |    |    |    +--- androidx.activity:activity-ktx:1.2.3 -> 1.3.1 (*)
-|    |    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 -> 2.4.1 (*)
-|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.1 (*)
-|    |    |    |    +--- androidx.annotation:annotation-experimental:1.1.0
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.10 (*)
-|    |    |    +--- androidx.slidingpanelayout:slidingpanelayout:1.2.0
-|    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|    |    |    |    +--- androidx.customview:customview:1.1.0 (*)
-|    |    |    |    +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
-|    |    |    |    +--- androidx.window:window:1.0.0
-|    |    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.10 (*)
-|    |    |    |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
-|    |    |    |    |    +--- androidx.annotation:annotation:1.2.0
-|    |    |    |    |    +--- androidx.collection:collection:1.1.0 (*)
-|    |    |    |    |    \--- androidx.core:core:1.3.2 -> 1.7.0 (*)
-|    |    |    |    \--- androidx.transition:transition:1.4.1 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.10 (*)
-|    |    \--- androidx.navigation:navigation-runtime-ktx:2.4.2
-|    |         +--- androidx.navigation:navigation-runtime:2.4.2 (*)
-|    |         \--- androidx.navigation:navigation-common-ktx:2.4.2
-|    |              \--- androidx.navigation:navigation-common:2.4.2 (*)
+|    +--- androidx.navigation:navigation-ui:2.4.2
+|    |    +--- androidx.navigation:navigation-runtime:2.4.2 (*)
+|    |    +--- androidx.customview:customview:1.1.0 (*)
+|    |    +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
+|    |    +--- com.google.android.material:material:1.4.0-beta01 -> 1.6.0-alpha01 (*)
+|    |    +--- androidx.annotation:annotation-experimental:1.1.0
+|    |    \--- androidx.transition:transition:1.3.0 -> 1.4.1 (*)
+|    +--- androidx.lifecycle:lifecycle-viewmodel:2.4.1 (*)
+|    \--- androidx.lifecycle:lifecycle-livedata-core:2.4.1 (*)
-|    +--- androidx.navigation:navigation-ui-ktx:2.4.2
-|    |    +--- androidx.navigation:navigation-ui:2.4.2
-|    |    |    +--- androidx.navigation:navigation-runtime:2.4.2 (*)
-|    |    |    +--- androidx.customview:customview:1.1.0 (*)
-|    |    |    +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
-|    |    |    +--- com.google.android.material:material:1.4.0-beta01 -> 1.6.0-alpha01 (*)
-|    |    |    +--- androidx.annotation:annotation-experimental:1.1.0
-|    |    |    \--- androidx.transition:transition:1.3.0 -> 1.4.1 (*)
-|    |    \--- androidx.navigation:navigation-runtime-ktx:2.4.2 (*)
-|    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.4.1 (*)
-|    \--- androidx.lifecycle:lifecycle-livedata-ktx:2.4.1
-|         +--- androidx.lifecycle:lifecycle-livedata:2.4.1 (*)
-|         +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.4.1 (*)
-|         +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
-|         \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.0 -> 1.5.2 (*)
++--- com.automattic:about:1.0.0
+|    \--- androidx.navigation:navigation-compose:2.4.0-beta02
+|         \--- androidx.navigation:navigation-runtime-ktx:2.4.0-beta02
+|              +--- androidx.navigation:navigation-runtime:2.4.0-beta02 -> 2.4.2 (*)
+|              \--- androidx.navigation:navigation-common-ktx:2.4.0-beta02
+|                   \--- androidx.navigation:navigation-common:2.4.0-beta02 -> 2.4.2 (*)
+\--- com.automattic:stories:2.0.0
+     \--- androidx.lifecycle:lifecycle-livedata-ktx:2.2.0 -> 2.4.1
+          +--- androidx.lifecycle:lifecycle-livedata:2.4.1 (*)
+          +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.4.1 (*)
+          +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
+          \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.0 -> 1.5.2 (*)
-+--- project :libs:editor
-|    +--- org.jsoup:jsoup:1.10.3 -> 1.11.3
-|    +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
-|    +--- androidx.gridlayout:gridlayout:1.0.0 (*)
-|    \--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-+--- com.automattic:about:1.0.0
-|    \--- androidx.navigation:navigation-compose:2.4.0-beta02
-|         \--- androidx.navigation:navigation-runtime-ktx:2.4.0-beta02 -> 2.4.2 (*)
-\--- com.automattic:stories:2.0.0
-     +--- androidx.navigation:navigation-fragment-ktx:2.0.0 -> 2.4.2 (*)
-     +--- androidx.navigation:navigation-ui-ktx:2.0.0 -> 2.4.2 (*)
-     \--- androidx.lifecycle:lifecycle-livedata-ktx:2.2.0 -> 2.4.1 (*)

Please review and act accordingly

wpmobilebot · 2022-12-02T15:21:23Z

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17605-03dd9d1.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`WordPress`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`03dd9d1`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot · 2022-12-02T15:23:34Z

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17605-03dd9d1.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`Jetpack`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`03dd9d1`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

oguzkocer · 2022-12-05T12:20:20Z

libs/mocks/build.gradle


 dependencies {
    implementation("com.github.tomakehurst:wiremock:$wiremockMocksVersion") {
-        exclude group: 'com.fasterxml.jackson.core', module: 'jackson-core'


@ParaskP7 Do you know why this exclude was necessary previously but now it's not?

👋 @oguzkocer !

Actually, I believe this was either a misconfiguration during the initial setup (see here) or after some updates of this WireMock dependency, this exclusion was no longer necessary and even causing trouble (see here).

As such, I thought it is better to remove this configuration and make the WireMock configuration consistent everywhere, for example (here, here for WPAndroid and here for WCAndroid).

Wdyt? 🤔

Sounds good to me.

ParaskP7 added 16 commits December 2, 2022 11:09

Deps: Remove unnecessary jackson core exclusion for wiremock dependency

d47691f

Deps: Move apache http client android version to android test section

3adae10

This 'apacheHttpClientAndroidVersion' is soley connected to the WireMock configuration, which is 'Android Test' related only.

Deps: Rename apache http client android to wiremock http client version

d62282c

Since the 'apacheHttpClientAndroidVersion' is solely connected to the WireMock configuration, it is better if it is renamed accordingly to make this more explicit going forward.

Deps: Replace androidx lifecycle livedata ktx with core dependency

2559a72

The 'androidx.lifecycle:lifecycle-livedata-ktx' dependency is unused. The 'androidx.lifecycle:lifecycle-livedata-core' is the one actually used, and that should be declared directly instead.

Deps: Replace androidx lifecycle viewmodel ktx with viewmodel dependency

a38490e

The 'androidx.lifecycle:lifecycle-viewmodel-ktx' dependency is unused. The 'androidx.lifecycle:lifecycle-viewmodel' is the one actually used, and that should be declared directly instead.

Deps: Group androidx legacy dependencies together

ab37810

Deps: Group androidx test espresso dependencies together

03dd9d1

Also, the associated 'accessibility' related comment was removed as self-explanatory.

ParaskP7 added Tech Debt dependency update labels Dec 2, 2022

ParaskP7 added this to the Future milestone Dec 2, 2022

ParaskP7 requested a review from oguzkocer December 2, 2022 15:01

ParaskP7 self-assigned this Dec 2, 2022

ParaskP7 mentioned this pull request Dec 2, 2022

Dependency Updates - Remove Unused Dependencies #17555

Closed

2 tasks

oguzkocer reviewed Dec 5, 2022

View reviewed changes

ParaskP7 mentioned this pull request Dec 5, 2022

Dependency Updates - AndroidX Test Batch #17556

Closed

5 tasks

oguzkocer approved these changes Dec 5, 2022

View reviewed changes

ParaskP7 merged commit a0bff46 into trunk Dec 5, 2022

ParaskP7 deleted the deps/remove-unused-dependencies-for-libs branch December 5, 2022 13:32

This was referenced Dec 5, 2022

[Dependency Updates] Remove Unused Dependencies for WordPress Module #17620

Merged

Dependency Updates - Android Test Batch #17558

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dependency Updates] Remove Unused Dependencies for Libs Modules#17605

[Dependency Updates] Remove Unused Dependencies for Libs Modules#17605
ParaskP7 merged 16 commits intotrunkfrom
deps/remove-unused-dependencies-for-libs

ParaskP7 commented Dec 2, 2022 •

edited

Loading

Uh oh!

wpmobilebot commented Dec 2, 2022

Uh oh!

wpmobilebot commented Dec 2, 2022

Uh oh!

wpmobilebot commented Dec 2, 2022

Uh oh!

oguzkocer Dec 5, 2022

Uh oh!

ParaskP7 Dec 5, 2022

Uh oh!

oguzkocer Dec 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ParaskP7 commented Dec 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Notes

Uh oh!

wpmobilebot commented Dec 2, 2022

The PR caused the following dependency changes:

Uh oh!

wpmobilebot commented Dec 2, 2022

Uh oh!

wpmobilebot commented Dec 2, 2022

Uh oh!

oguzkocer Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

ParaskP7 Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

oguzkocer Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ParaskP7 commented Dec 2, 2022 •

edited

Loading