Skip to content

Update wiremock dependency and include jackson-core group#12082

Merged
jkmassel merged 1 commit intodevelopfrom
update-wiremock-dependency
Jun 2, 2020
Merged

Update wiremock dependency and include jackson-core group#12082
jkmassel merged 1 commit intodevelopfrom
update-wiremock-dependency

Conversation

@oguzkocer
Copy link
Copy Markdown
Contributor

It looks like we excluded the jackson-core group from the wiremock dependency in #9422, but with the latest Sentry SDK upgrade this has caused connected tests to fail with the following error:

java.lang.NoClassDefFoundError: Failed resolution of: Lcom/fasterxml/jackson/core/ObjectCodec;

This PR re-adds the jackson-core group and updates the wiremock dependency to the latest version.

@oguzkocer oguzkocer added this to the 15.1 milestone Jun 2, 2020
@oguzkocer oguzkocer requested review from jkmassel and rachelmcr June 2, 2020 16:23
@peril-wordpress-mobile
Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APK here.

@oguzkocer oguzkocer added 1 and removed 1 labels Jun 2, 2020
@jkmassel jkmassel merged commit 36eebcf into develop Jun 2, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

Fails
🚫

Danger failed to run /app/danger-0.pllbe5wqcff.ts.

Error TypeError

Cannot read property 'base' of undefined
TypeError: Cannot read property 'base' of undefined
    at Object.exports.default (/app/danger-0.pllbe5wqcff.ts:18:49)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

13|         // Skip for PRs with "Releases" label
14|         const releases = githubLabels.some(label => label.name.includes("Releases"));
15|         if (releases) {
16|             return;
17|         }
---------------------------------------------------^
18| 
19|         // Skip for PRs for wip features unless the PR is against "develop" or "release/x.x" branches
20|         const targetsDevelop = danger.github.pr.base.ref == "develop";
21|         const targetsRelease = danger.github.pr.base.ref.startsWith("release/");

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants