Issue/remove deprecated gif picker#14727
Merged
planarvoid merged 4 commits intodevelopfrom May 28, 2021
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APK here. |
ParaskP7
added a commit
that referenced
this pull request
Dec 5, 2022
This dependency seems that was lastly used only for the no longer existing 'TenorProviderTest' test class (see 47ac89a), which was added as part of this #11587 PR. However, as part of this #14727 PR, this 'TenorProviderTest' test class got removed (see f29f6d0). As such, this leftover from back then can be now safely removed. PS: And with this change, the corresponding 'androidxTestCoreVersion' version is no longer necessary for unit test. As such, it is being moved from the more inclusive 'test' section to the more specific 'android test' section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes deprecated
GifPickerActivityand all the related classes.We were using a
KEY_SAVED_MEDIA_MODEL_LOCAL_IDSconstant fromGifPickerActivity, which I extracted intoMediaPickerConstants.To test:
GifPickerActivitywas not in use, so there is not much to test.PR submission checklist:
RELEASE-NOTES.txtif necessary.