Conversation
Generated by 🚫 dangerJS |
Contributor
|
I'm bumping this to If you'd like it to be released as part of |
khaykov
approved these changes
Aug 11, 2019
Contributor
khaykov
left a comment
There was a problem hiding this comment.
Looks good! Nothing seems broken so far 👍
ParaskP7
added a commit
that referenced
this pull request
Dec 5, 2022
This dependency seems that was lastly used only for some stats related classes that are no longer existing, like the 'StatsVisitorsAndViewsFragment' via teh 'com.jjoe64.graphview' import. However, as part of the #10282 PR, all those stats related classes got removed (see da7d52f). As such, this leftover from back then can be now safely removed. PS: Also, as part of this change the 'GraphView' dependency, and in general, the complete list of 'LGPL v3' licensed dependencies is now removed from the 'licenses.html' document for both, the WordPress and Jetpack apps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all the unused code from the old stats. I think you can safely ignore most of the code. There are several things that were updated and might be broken:
OldStatsActivityandStatsAbstractFragmenttoStatsActivityandStatsViewAllFragment. This change should be pretty safe.FormattableContentClickHandlershould be safe. I've removed the fields that were not consumed inStatsViewAllActivityTo test - there should be no functionality change:
Blog postsUpdate release notes:
RELEASE-NOTES.txt.