Skip to content

Gutenberg: update to v1.22.0#11224

Merged
cameronvoell merged 18 commits intodevelopfrom
gutenberg/integrate_release_1.22.0
Feb 8, 2020
Merged

Gutenberg: update to v1.22.0#11224
cameronvoell merged 18 commits intodevelopfrom
gutenberg/integrate_release_1.22.0

Conversation

@hypest
Copy link
Copy Markdown
Contributor

@hypest hypest commented Feb 3, 2020 •
edited
Loading

Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1849

Changes

  • gb-mobile-1686 Adding retry feature to mobile apiFetch handler
  • gb-mobile-1841 Show the media edit icon only if the block is selected
  • gb-mobile-1835 Make inserter to show options on long-press to add before/after
  • gb-mobile-1821 Fix: AppenderButton and Separator in InnerBlock
  • gb-mobile-1450 Update React Native to 0.61.5
  • gb-mobile-1799 Adjust to Gutenberg master to fix issues with icons, the primitives package and a new dependency for data
  • gb-mobile-1786 Hardcode Android RN version in bridge and aztec

* gb-mobile-1817 External media links from another app will not work if the block editor is enabled Available only on WPiOS for now
* gb-mobile-1827 Fixes the Image's media button not displaying the Picker Available only on WPiOS for now
* gb-mobile-1847 Remove DEV flag from Media Editor button Available only on WPiOS for now
* gb-mobile-1872 Add media edit icon to image block Available only on WPiOS for now

Changes - After the cut was started

To test:

  • Smoke test the app and report if all OK
  • Please try the items in the changelog above and report the test outcome of each one that you tested

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hypest hypest added this to the 14.2 milestone Feb 3, 2020
@hypest hypest self-assigned this Feb 3, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 3, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@hypest hypest mentioned this pull request Feb 3, 2020
Merged
2 tasks
@hypest hypest requested a review from marecar3 February 3, 2020 14:38
@hypest hypest marked this pull request as ready for review February 3, 2020 15:24
@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Feb 6, 2020 •
edited
Loading

Tested 4a1e261:

Legend:
🤷‍♂️ : not exposed to the apps yet
⏳ : in progress
❌ : failed
✅ : passes
⚠️ : passes but there are notes

⏳ Smoke test
⚠️ gb-mobile-1686 Adding retry feature to mobile apiFetch handler. Successful few test tries except for my first try where image block remained empty even after resuming connectivity. Commented here
✅ gb-mobile-1817 External media links from another app will not work if the block editor is enabled
✅ gb-mobile-1835 Make inserter to show options on long-press to add before/after
⏳ gb-mobile-1450 Update React Native to 0.61.5
✅ gb-mobile-1799 Adjust to Gutenberg master to fix issues with icons, the primitives package and a new dependency for data
✅ gb-mobile-1786 Hardcode Android RN version in bridge and aztec
✅ gb-mobile-1856 Fix gallery size labels

🤷‍♂️ gb-mobile-1830 (DEV only) Fix gallery upload sync
🤷‍♂️ gb-mobile-1825 (DEV only) Fix: fix appender style
🤷‍♂️ gb-mobile-1776 (DEV only) Allow configuration of selection/caret color on Aztec view
🤷‍♂️ gb-mobile-1785 (DEV only) Style improvements for template previews
🤷‍♂️ gb-mobile-1762 (DEV only) Use patch-package to fix max-depth issue in react-native (temporary)
🤷‍♂️ gb_mobile_1821 (DEV only) Fix: AppenderButton and Separator in InnerBlock

⏳ gb-mobile-1827 Fixes the Image's media button not displaying the Picker available only on WPiOS for now
⏳ gb-mobile-1841 Show the media edit icon only if the block is selected available only on WPiOS for now
⏳ gb-mobile-1847 Remove DEV flag from Media Editor button available only on WPiOS for now
⏳ gb-mobile-1872 Add media edit icon to image block available only on WPiOS for now

@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Feb 6, 2020 •
edited
Loading

Issues found so far:

  1. Typing "Enter" to create a new paragraph block causes the blocks list to jump to the top and scroll down to the new block. Ticket: Scrolling jump to top when typing a new paragraph block gutenberg-mobile#1870
  2. Merging blocks by hitting "backspace" doesn't work if you first edit one or more chars from the start of the block. Ticket: Case where backspace will not merge Paragraph Blocks gutenberg-mobile#1865
  3. Quote block "jumping/quirk" trying to add a newline. This seems to already exist in the production app as well.
  4. Keyboard doesn't hide when hitting the "close keyboard" button on the toolbar while being in the shortcode block and the Image caption (same on Code block but that block is behind "DEV" flag). Ticket: [Android] Keyboard dismiss button doesn't dismiss the keyboard in the Shortcode block gutenberg-mobile#1864

@etoledom etoledom mentioned this pull request Feb 7, 2020
Merged
3 tasks
mchowning
mchowning approved these changes Feb 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cameronvoell cameronvoell merged commit 0702443 into develop Feb 8, 2020
@hypest hypest deleted the gutenberg/integrate_release_1.22.0 branch February 10, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marecar3 marecar3 Awaiting requested review from marecar3

1 more reviewer

@mchowning mchowning mchowning approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hypest hypest

Labels

None yet

Projects

None yet

Milestone

14.2

Development

Successfully merging this pull request may close these issues.

4 participants

@hypest @mchowning @cameronvoell @mkevins