Hardcode Android RN version in bridge and aztec#1786
Merged
Conversation
react-native-aztec This is a temporary fix to get the Jitpack builds back to green while I work on a solution that doesn't use hardcoded values.
cameronvoell
approved these changes
Jan 20, 2020
Contributor
cameronvoell
left a comment
There was a problem hiding this comment.
Verified the example app and WordPress Android app build locally with this change, and noted the successful green build on jitpack.
This was referenced Feb 3, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix, building the Android
react-native-gutenberg-bridgeorreact-native-aztecmodules directly (i.e., where they are therootProject) would use an older version of react native. With a recent change to the project this resulted in a build error. Jitpack builds those modules directly, so builds on Jitpack were failing.This is a temporary fix to get the Jitpack builds back to green while I work on a solution that doesn't use hardcoded values. I expect to open a new PR with a cleaner solution later today.
I'm not updating the value in the relevant package.json files in this temporary-fix-PR because it seems that we need version
v0.60.0-patchedin the package.json files, but we need to drop thevfor the java dependency version.To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.