Skip to content

Make inserter to show options on long-press to add before/after#1835

Merged
ceyhun merged 20 commits intodevelopfrom
issue/1433-long-press-on-inserter-to-show-add-before-after
Jan 30, 2020
Merged

Make inserter to show options on long-press to add before/after#1835
ceyhun merged 20 commits intodevelopfrom
issue/1433-long-press-on-inserter-to-show-add-before-after

Conversation

@ceyhun
Copy link
Copy Markdown
Contributor

@ceyhun ceyhun commented Jan 29, 2020

Fixes #1433

To test: see Gutenberg PR: WordPress/gutenberg#18791

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ceyhun ceyhun changed the title Issue/1433 long press on inserter to show add before after Make inserter to show options on long-press to add before/after Jan 29, 2020
@ceyhun ceyhun requested a review from SergioEstevao January 29, 2020 16:24
@ceyhun ceyhun added this to the 1.22 milestone Jan 29, 2020
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good thanks for this change!

@ceyhun ceyhun merged commit 28f7f7e into develop Jan 30, 2020
@ceyhun ceyhun deleted the issue/1433-long-press-on-inserter-to-show-add-before-after branch January 30, 2020 12:15
@designsimply
Copy link
Copy Markdown
Contributor

Looks lovely! 😍

Screenshot_20200221-160053

Tested with WPAndroid 14.2-rc-2 on Pixel 3 Android 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: Long-press on inserter to show options for "add above" and "add below"

3 participants