Skip to content

Remove DEV flag from Media Editor button#1847

Merged
leandroalonso merged 1 commit intodevelopfrom
issue/1583_remove_dev_flag_from_media_edit_button
Jan 31, 2020
Merged

Remove DEV flag from Media Editor button#1847
leandroalonso merged 1 commit intodevelopfrom
issue/1583_remove_dev_flag_from_media_edit_button

Conversation

@leandroalonso
Copy link
Copy Markdown
Contributor

@leandroalonso leandroalonso commented Jan 31, 2020

Remove the __DEV__ flag so the Media Editor button will be available for iOS in production too.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@leandroalonso leandroalonso added this to the 1.22 milestone Jan 31, 2020
@leandroalonso leandroalonso self-assigned this Jan 31, 2020
etoledom
etoledom approved these changes Jan 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: !

@leandroalonso leandroalonso merged commit b7ffa8c into develop Jan 31, 2020
@leandroalonso leandroalonso deleted the issue/1583_remove_dev_flag_from_media_edit_button branch January 31, 2020 14:52
This was referenced Feb 3, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@leandroalonso leandroalonso

Labels

Media [Type] Task

Projects

None yet

Milestone

1.22

Development

Successfully merging this pull request may close these issues.

2 participants

@leandroalonso @etoledom