Add Starlight Markdown Blocks to community plugins#2998
Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
size-limit report 📦
|
trueberryless
left a comment
There was a problem hiding this comment.
LGTM overall 🎉
Just left one very small suggestion...
| <LinkCard | ||
| href="https://delucis.github.io/starlight-markdown-blocks/" | ||
| title="starlight-markdown-blocks" | ||
| description="Extend Starlight’s Markdown asides syntax with custom block types." |
There was a problem hiding this comment.
I recommend using the straight quotation mark here because then it is consistent with the other entries and Astro converts it to a smart apostrophe nonetheless...
| description="Extend Starlight’s Markdown asides syntax with custom block types." | |
| description="Extend Starlight's Markdown asides syntax with custom block types." |
There was a problem hiding this comment.
I don’t think this would get converted by smartypants as it’s not in Markdown?
For example, here it’s shown as a straight quote rather than an apostrophe:
I type ’ and “” instinctively without thinking though, so appreciate you double checking!
There was a problem hiding this comment.
I don’t think this would get converted by smartypants as it’s not in Markdown?
Hmm, true. Didn't think about that. Maybe we should update the other apostrophes in this file and other components too then? 🤔
* main: (67 commits) [ci] format i18n(de): update `plugins.mdx` (withastro#2988) remove ghostcms plugin (withastro#2999) Add Starlight Markdown Blocks to community plugins (withastro#2998) [ci] release (withastro#2992) Add npm social icon (withastro#2969) [ci] format fix: Search ranking on merge indexes (withastro#2994) update astro to the latest version (withastro#2948) add own plugin and enhance some other descriptions (withastro#2996) chore: disable renovate dashboard (withastro#2995) feat(tailwind): support @astrojs/tailwind v6 (withastro#2991) i18n(fr): update `resources/plugins` (withastro#2990) i18n(ko-KR): update `plugins.mdx` (withastro#2987) chore: disable renovate package manager updates (withastro#2985) chore: disable renovate docker updates (withastro#2982) Update labeler config (withastro#2983) chore(deps): update github-actions (withastro#2979) [ci] format chore: disable automated PRs for npm (withastro#2978) ...
Description