Skip to content

Add npm social icon#2969

Merged
delucis merged 1 commit intowithastro:mainfrom
webpro:feat/add-npm-social-icon
Mar 21, 2025
Merged

Add npm social icon#2969
delucis merged 1 commit intowithastro:mainfrom
webpro:feat/add-npm-social-icon

Conversation

@webpro
Copy link
Copy Markdown
Contributor

@webpro webpro commented Mar 18, 2025

Description

  • Closes # - did not create an issue first
  • Add social icon for npm
  • A work of art:
Screenshot 2025-03-18 at 1 55 39 PM

Can't make it any smaller (SVGOMG makes it larger)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 18, 2025

🦋 Changeset detected

Latest commit: df502e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Mar 18, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 18, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit df502e1
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67d9ad99a0cea70008063f44
😎 Deploy Preview https://deploy-preview-2969--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@webpro webpro force-pushed the feat/add-npm-social-icon branch 2 times, most recently from 6c43639 to cf740bf Compare March 18, 2025 13:07
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @webpro! Was just thinking about this last week while setting up a docs site, so I think it’s a good addition.

Noting that we technically do already have an npm icon included although it looks a bit different as it’s the one from the Seti UI VS Code icon set:

npm icon labelled seti:npm

I guess the argument for the new n icon is that it’s better designed to be displayed in a small square icon space? Do we have any examples of sites using one or the other of these icons?

@webpro
Copy link
Copy Markdown
Contributor Author

webpro commented Mar 18, 2025

Thanks @webpro! Was just thinking about this last week while setting up a docs site, so I think it’s a good addition.

Noting that we technically do already have an npm icon included although it looks a bit different as it’s the one from the Seti UI VS Code icon set:

npm icon labelled seti:npm I guess the argument for the new `n` icon is that it’s better designed to be displayed in a small square icon space? Do we have any examples of sites using one or the other of these icons?

In my experience the "n" is pretty common. See the favicon and the icon down in the footer of the npm website itself, e.g. https://www.npmjs.com/about

Seeing that this bigger icon has a slightly rounded corner I updated the SVG.

@webpro
Copy link
Copy Markdown
Contributor Author

webpro commented Mar 18, 2025

Update:

Screenshot 2025-03-18 at 6 29 41 PM

@webpro webpro force-pushed the feat/add-npm-social-icon branch from cf740bf to df502e1 Compare March 18, 2025 17:29
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @webpro! Will merge this when we’re ready for our next patch release.

@delucis delucis added the 🌟 patch Change that triggers a patch release label Mar 21, 2025
@delucis delucis merged commit 4682c7a into withastro:main Mar 21, 2025
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Mar 21, 2025
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Mar 24, 2025
* main: (67 commits)
  [ci] format
  i18n(de): update `plugins.mdx` (withastro#2988)
  remove ghostcms plugin (withastro#2999)
  Add Starlight Markdown Blocks to community plugins (withastro#2998)
  [ci] release (withastro#2992)
  Add npm social icon (withastro#2969)
  [ci] format
  fix: Search ranking on merge indexes (withastro#2994)
  update astro to the latest version (withastro#2948)
  add own plugin and enhance some other descriptions (withastro#2996)
  chore: disable renovate dashboard (withastro#2995)
  feat(tailwind): support @astrojs/tailwind v6 (withastro#2991)
  i18n(fr): update `resources/plugins` (withastro#2990)
  i18n(ko-KR): update `plugins.mdx` (withastro#2987)
  chore: disable renovate package manager updates (withastro#2985)
  chore: disable renovate docker updates (withastro#2982)
  Update labeler config (withastro#2983)
  chore(deps): update github-actions (withastro#2979)
  [ci] format
  chore: disable automated PRs for npm (withastro#2978)
  ...
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants