Skip to content

feat(tailwind): support @astrojs/tailwind v6#2991

Merged
delucis merged 2 commits intomainfrom
feat/support-astro-tailwind-6
Mar 20, 2025
Merged

feat(tailwind): support @astrojs/tailwind v6#2991
delucis merged 2 commits intomainfrom
feat/support-astro-tailwind-6

Conversation

@florian-lefebvre
Copy link
Copy Markdown
Member

Description

  • What does this PR change? Updates the peer dep. I made it a patch since v6 doesn't change anything compared to v5

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: cceb7c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight-tailwind Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 tailwind Changes to Starlight’s Tailwind package label Mar 20, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 4cad8ba
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67dbf63fcbc6b10008a69f93
😎 Deploy Preview https://deploy-preview-2991--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
/index.html 6.93 KB (0%)
/_astro/*.js 25.76 KB (0%)
/_astro/*.css 13.8 KB (0%)

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit cceb7c3
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67dbf64d34d17300080eda92
😎 Deploy Preview https://deploy-preview-2991--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however in my opinion a minor bump should be the golden middle between "it's not a major change and we add a major peer dep change", but as the maintainers like...

Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @florian-lefebvre and to @trueberryless for reviewing 🙌

Re: minor vs patch bump — I think this is conceptually a bug fix as for people using v5 of the integration nothing changes, but it fixes things for anyone trying to use v6 (which itself doesn’t include any new functionality), so I’m happy leaving it a patch!

@delucis delucis merged commit b8a4800 into main Mar 20, 2025
15 checks passed
@delucis delucis deleted the feat/support-astro-tailwind-6 branch March 20, 2025 11:49
@astrobot-houston astrobot-houston mentioned this pull request Mar 20, 2025
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Mar 24, 2025
* main: (67 commits)
  [ci] format
  i18n(de): update `plugins.mdx` (withastro#2988)
  remove ghostcms plugin (withastro#2999)
  Add Starlight Markdown Blocks to community plugins (withastro#2998)
  [ci] release (withastro#2992)
  Add npm social icon (withastro#2969)
  [ci] format
  fix: Search ranking on merge indexes (withastro#2994)
  update astro to the latest version (withastro#2948)
  add own plugin and enhance some other descriptions (withastro#2996)
  chore: disable renovate dashboard (withastro#2995)
  feat(tailwind): support @astrojs/tailwind v6 (withastro#2991)
  i18n(fr): update `resources/plugins` (withastro#2990)
  i18n(ko-KR): update `plugins.mdx` (withastro#2987)
  chore: disable renovate package manager updates (withastro#2985)
  chore: disable renovate docker updates (withastro#2982)
  Update labeler config (withastro#2983)
  chore(deps): update github-actions (withastro#2979)
  [ci] format
  chore: disable automated PRs for npm (withastro#2978)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 tailwind Changes to Starlight’s Tailwind package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants