Conversation
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
trueberryless
left a comment
There was a problem hiding this comment.
One consideration about the new breaking labeler change
.github/labeler.yml
Outdated
| '🚨 action': | ||
| - .github/workflows/** | ||
| - changed-files: | ||
| - .github/workflows/** |
There was a problem hiding this comment.
Do we want to increase the specificy by using
| - .github/workflows/** | |
| - any-glob-to-any-file: ".github/workflows/**" |
This would later allow to make a list of the globs (if we ever need it) like this:
- any-glob-to-any-file: [ ".github/workflows/**", "other glob"]
.github/labeler.yml
Outdated
| '🚨 action': | ||
| - .github/workflows/** | ||
| - changed-files: | ||
| - .github/workflows/** |
There was a problem hiding this comment.
Based on the examples, shouldn't the structure be something like this?
'🚨 action':
- changed-files:
- any-glob-to-any-file:
- .github/workflows/**There was a problem hiding this comment.
Oh yeah… you’re right. Wow. What a terrible config format 😅
There was a problem hiding this comment.
I use it in my repos with "any-glob-to-any-files" and I'm not sure if it even works without, but I can confirm it works like this (example from some of my repos):
# See https://github.com/actions/labeler/tree/v5
"🚨 action":
- changed-files:
- any-glob-to-any-file: .github/workflows/**
"📝 changeset":
- changed-files:
- any-glob-to-any-file: "**/.changeset/**.{md,mdx}"
"🚧 config":
- changed-files:
- any-glob-to-any-file: "**/*config*.{js,ts,jsx,tsx,mjs,mts,json,yml,yaml,toml,cjs,cts}"
"✒️ documentation":
- changed-files:
- any-glob-to-any-file: "**/README.md"
"🌏 i18n":
- changed-files:
- all-globs-to-any-file: ["**/docs/**", "!**/docs/en/**"]
"🚀 manifest":
- changed-files:
- any-glob-to-any-file: "manifest*/**"
"📦 package":
- changed-files:
- any-glob-to-any-file: "**/packages/**"
- any-glob-to-any-file: "**/package.json"
"🏯 styles":
- changed-files:
- any-glob-to-any-file: "**/*.{css,scss,sass,less,styl}"
|
|
hahhaa, the desperation in the commit message is peak DX |
HiDeoo
left a comment
There was a problem hiding this comment.
No idea if the indentation changes from 2 spaces to 4 spaces is valid, but otherwise looks similar to the (horrible) examples.
* main: (67 commits) [ci] format i18n(de): update `plugins.mdx` (withastro#2988) remove ghostcms plugin (withastro#2999) Add Starlight Markdown Blocks to community plugins (withastro#2998) [ci] release (withastro#2992) Add npm social icon (withastro#2969) [ci] format fix: Search ranking on merge indexes (withastro#2994) update astro to the latest version (withastro#2948) add own plugin and enhance some other descriptions (withastro#2996) chore: disable renovate dashboard (withastro#2995) feat(tailwind): support @astrojs/tailwind v6 (withastro#2991) i18n(fr): update `resources/plugins` (withastro#2990) i18n(ko-KR): update `plugins.mdx` (withastro#2987) chore: disable renovate package manager updates (withastro#2985) chore: disable renovate docker updates (withastro#2982) Update labeler config (withastro#2983) chore(deps): update github-actions (withastro#2979) [ci] format chore: disable automated PRs for npm (withastro#2978) ...
Description
This aims to fix the GitHub labeler action that runs for every PR for compatibility with v5.
Their docs are pretty bad, but IIUC, they introduced different match types which means we need to use a
changed-fileskey for each of our existing labels.