fix: fs.readFile emit relative assets using cwd by icyJoseph · Pull Request #542 · vercel/nft

icyJoseph · 2025-09-24T22:02:36Z

In this input file:

const fs = require('fs');

fs.readFile('./asset1.txt')

fs.readFile(require.resolve('./asset2.txt'))

const _basePath = __dirname;
const asset3 = 'asset3.txt';
fs.readFileSync(_basePath + '/' + asset3, 'utf8');

We don't emit for fs.readFile('./asset1.txt'), but we should:

Regardless of where the code is (i.e. in which chunk it ends up in after bundling), readFile is always relative to process.cwd() which is set by Next.js to always be the project root (otherwise process.cwd() + "./foo" wouldn't work either

ijjk · 2025-09-24T22:23:55Z

src/analyze.ts

+      typeof staticChildValue.value === 'string' &&
+      staticChildValue.value.startsWith('.')
+    ) {
+      staticChildValue.value = path.resolve(dir, staticChildValue.value);


Are we matching behavior here? vercel/next.js#84155 seems like this is diverging

Mmm - yeah, I have it wrong here, I should use cwd - and update the test

if we have:

├── hello.json ├── index.js ├── lib │ └── index.js └── package.json

With lib/index.js as:

const fs = require("fs/promises") fs.readFile('./hello.json', 'utf-8').then(console.log)

And index.js as:

require("./lib")

Then node index.js resolves hello.json in lib from the cwd, not the lib/index.js file. Also follows that node lib/index.js resolves from the root too.

In this branch, running npm run build && node out/cli.js print test/unit/fs-emission/input.js won't output asset1.txt cuz it doesn't exist in the root.

If we place a dummy asset1.txt at the root and re-run, then we trace the file.

I think we have two variations one with cwd at the root and once in the fixture

Yes, both tests pass with that condition - I shared that as an example of how to test manually.

src/analyze.ts

test/unit/fs-relative-emission/main/input.js

test/unit.test.js

styfle

Great work, thanks! 🥇

github-actions · 2025-09-26T17:07:38Z

🎉 This PR is included in version 0.30.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This reverts commit dc4ab0b.

Reverts #542 This seems to cause bugs such as this one: - #545

This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [@vercel/nft](https://redirect.github.com/vercel/nft) | [`0.30.2` -> `0.30.3`](https://renovatebot.com/diffs/npm/@vercel%2fnft/0.30.2/0.30.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@vercel%2fnft/0.30.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vercel%2fnft/0.30.2/0.30.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>vercel/nft (@vercel/nft)</summary> ### [`v0.30.3`](https://redirect.github.com/vercel/nft/releases/tag/0.30.3) [Compare Source](https://redirect.github.com/vercel/nft/compare/0.30.2...0.30.3) ##### Bug Fixes - Revert "fs.readFile emit relative assets using cwd" ([#547](https://redirect.github.com/vercel/nft/issues/547)) ([78b3823](https://redirect.github.com/vercel/nft/commit/78b3823b557582b3f35925df5df522abd63a50d9)), closes [vercel/nft#542](https://redirect.github.com/vercel/nft/issues/542) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).

fix: fs.readFile emit relative assets

1dc3ff5

icyJoseph requested review from a team, ijjk and styfle as code owners September 24, 2025 22:02

ijjk reviewed Sep 24, 2025

View reviewed changes

ijjk mentioned this pull request Sep 24, 2025

Turbopack: fix NFT of readFileSync of relative path vercel/next.js#84155

Merged

fix: use cwd for readFile

56b9f25

icyJoseph changed the title ~~fix: fs.readFile emit relative assets~~ fix: fs.readFile emit relative assets using cwd Sep 24, 2025

styfle reviewed Sep 25, 2025

View reviewed changes

src/analyze.ts Outdated Show resolved Hide resolved

icyJoseph added 2 commits September 25, 2025 11:53

refactor: do a follow upcheck if not absolute path

7119cc2

test: tracing relative file access

1c83296

styfle reviewed Sep 26, 2025

View reviewed changes

test/unit/fs-relative-emission/main/input.js Outdated Show resolved Hide resolved

styfle reviewed Sep 26, 2025

View reviewed changes

test/unit.test.js Show resolved Hide resolved

Apply suggestions from code review

a0e0038

styfle approved these changes Sep 26, 2025

View reviewed changes

Merge branch 'main' into fix/emit-static-child-asset-for-relative-paths

6021c1e

styfle enabled auto-merge (squash) September 26, 2025 16:57

styfle merged commit dc4ab0b into main Sep 26, 2025
12 checks passed

styfle deleted the fix/emit-static-child-asset-for-relative-paths branch September 26, 2025 17:03

github-actions bot added the released label Sep 26, 2025

florian-lefebvre mentioned this pull request Oct 2, 2025

0.30.2 scans too many files #545

Open

styfle added a commit that referenced this pull request Oct 16, 2025

Revert "fix: fs.readFile emit relative assets using cwd (#542)"

41d5520

This reverts commit dc4ab0b.

styfle mentioned this pull request Oct 16, 2025

fix: Revert "fs.readFile emit relative assets using cwd" #547

Merged

styfle added a commit that referenced this pull request Oct 16, 2025

fix: Revert "fs.readFile emit relative assets using cwd" (#547)

78b3823

Reverts #542 This seems to cause bugs such as this one: - #545

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fs.readFile emit relative assets using cwd#542

fix: fs.readFile emit relative assets using cwd#542
styfle merged 6 commits intomainfrom
fix/emit-static-child-asset-for-relative-paths

icyJoseph commented Sep 24, 2025

Uh oh!

ijjk Sep 24, 2025

Uh oh!

icyJoseph Sep 24, 2025

Uh oh!

icyJoseph Sep 24, 2025 •

edited

Loading

Uh oh!

icyJoseph Sep 24, 2025

Uh oh!

ijjk Sep 25, 2025

Uh oh!

icyJoseph Sep 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

styfle left a comment

Uh oh!

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

icyJoseph commented Sep 24, 2025

Uh oh!

ijjk Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

icyJoseph Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

icyJoseph Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

icyJoseph Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

ijjk Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

icyJoseph Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

styfle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

icyJoseph Sep 24, 2025 •

edited

Loading