fix: add special case for geoip-lite#446
Merged
styfle merged 3 commits intovercel:mainfrom Oct 22, 2024
Merged
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
styfle
approved these changes
Oct 22, 2024
Member
styfle
left a comment
There was a problem hiding this comment.
Looks good!
We can merge this one but I think a better solution would be fixing the static analysis for the fallback here:
geoip-lite
|
🎉 This PR is included in version 0.27.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, nft can not handle data assets of
geoip-litepackage properly. Error message like below ⬇️Test Code
This PR adds essential data files as assets for
geoip-litein special-case to solve it.