fix: Support browser overrides in package.json#424
Merged
Conversation
ijjk
approved these changes
Jun 5, 2024
Member
ijjk
left a comment
There was a problem hiding this comment.
This makes sense to me and will be good so we can trace for react-server and other conditions as well
|
🎉 This PR is included in version 0.27.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kodiakhq bot
pushed a commit
to vercel/vercel
that referenced
this pull request
Jun 6, 2024
See vercel/nft#424 for more details.
kodiakhq bot
added a commit
that referenced
this pull request
Jul 11, 2024
…`false` (#427) We [recently shipped](#424) support for the `browser` field, but we discovered an edge case where instead of mapping to another string, the value could be `false` (eg, [`object-inspect`](https://github.com/inspect-js/object-inspect/blob/main/package.json#L82)), which indicates that this module should be treated as an empty object (`{}`) (evidenced by its usage [here](https://github.com/inspect-js/object-inspect/blob/main/index.js#L68-L70)). The code was previously erroring on the string's `startsWith` checks, causing the entire package to be omitted from the file mapping result. This ensures that if the value is `false` we'll continue on. --------- Co-authored-by: Steven <steven@ceriously.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This was referenced Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
browsersectionpackage.jsonis used to expand a list of dependent files. The downstream build tool would normally do the right thing and use thebrowsersection for bundling correctly. I tested the bundling itself on esbuild and WebPack, and it works correctly. All that's needed is to make sure the files are there.