fix: Add special case for Serial Port binary (.node) modules#415
Merged
styfle merged 2 commits intovercel:mainfrom May 8, 2024
Merged
fix: Add special case for Serial Port binary (.node) modules#415styfle merged 2 commits intovercel:mainfrom
styfle merged 2 commits intovercel:mainfrom
Conversation
Tested with prebuilds and compiling serialport from source
Member
|
Please add an integration test in |
Contributor
Author
|
Good idea to add an integration test. I noticed another one of the binary .node special cases had an integration test. |
Contributor
Author
|
Just a note to myself that currently one integration test fails with the error below before I add my new integration test |
Contributor
Author
|
This has been updated with an integrating test. |
|
🎉 This PR is included in version 0.26.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
styfle
added a commit
to vercel/next.js
that referenced
this pull request
May 16, 2024
- vercel/nft#415 ([e001d05](vercel/nft@e001d05)) - vercel/nft#417 ([ddc5cba](vercel/nft@ddc5cba)) - vercel/nft#419 ([db6c65a](vercel/nft@db6c65a))
panteliselef
pushed a commit
to panteliselef/next.js
that referenced
this pull request
May 20, 2024
- vercel/nft#415 ([e001d05](vercel/nft@e001d05)) - vercel/nft#417 ([ddc5cba](vercel/nft@ddc5cba)) - vercel/nft#419 ([db6c65a](vercel/nft@db6c65a))
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
- vercel/nft#415 ([e001d05](vercel/nft@e001d05)) - vercel/nft#417 ([ddc5cba](vercel/nft@ddc5cba)) - vercel/nft#419 ([db6c65a](vercel/nft@db6c65a))
This was referenced Sep 19, 2024
gijs-martens
pushed a commit
to gijs-martens/next.js
that referenced
this pull request
Jul 2, 2025
- vercel/nft#415 ([e001d05](vercel/nft@e001d05)) - vercel/nft#417 ([ddc5cba](vercel/nft@ddc5cba)) - vercel/nft#419 ([db6c65a](vercel/nft@db6c65a))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with prebuilds and compiling serialport from source