USWDS - Accordion: Windows High Contrast Mode#4521
Merged
Conversation
Because currently, it is not testing anything.
The following updates have been made to remove redundancies with the updated Getting Started guidance for developers and per conversation with the dev team: –"Download and install" has been made more specific: "Download and install without npm." –"Install using npm" has been removed. References to this section have tentatively been replaced with "NEW LINK," and prior to publication, will be replaced with the link to the updated web guidance for Getting Started for devs. –Content of "Use another framework or package manager" has been moved up to appear under "Using the design system." –"Accessibility" has been updated to note a few of the tools we use to ensure USWDS is accessible.
Added link to new dev guidance
Co-authored-by: James Mejia <james.mejia@gsa.gov>
8 tasks
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…directs-1.14.8 Bump follow-redirects from 1.14.7 to 1.14.8
mejiaj
suggested changes
Feb 15, 2022
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
Added some initial comments. Let's contain any HCM changes to the appropriate media query. Having them in as default could be confusing.
[Docs] - [CONTRIBUTING]: Fix broken "Browser Support" link
Tests: Update "Behavior" spec to test expected behavior
USWDS - Combobox: add aria-controls for 508 compliance
Icon: Remove inline style in GitHub icon to fix CSP error
…vior on primary-link
Change fractal output directory to standard Federalist setup.
USWDS Footer - bug fix: reveal hidden content at 480px window width
Use partial pixel to support high dpi
USWDS 2.13.2
Sync 2.13.2
Post Getting Started Updates_Nov 30, 2021
mejiaj
suggested changes
Mar 16, 2022
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall! Added some suggestions.
Also, don't forget to run prettier for formatting.
mejiaj
reviewed
Mar 17, 2022
added 2 commits
March 18, 2022 14:50
thisisdano
reviewed
Mar 21, 2022
thisisdano
left a comment
Contributor
There was a problem hiding this comment.
LGTM once James's comments are addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview
Accordion →
Description
Resolves #4517 accordion issues
Replaced the
add-background-svgfunctions withplace-iconin order to ensure visibility in Windows High Contrast mode.Additional information
Currently:
After fix:
Works with light or dark themes
Default view
This solution maintains appearance outside of WHC as well.
Current build on left // Fix build on the right
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.