Skip to content

Change fractal output directory to standard Federalist setup.#4532

Merged
thisisdano merged 2 commits into
developfrom
jm-update-federalist-develop
Feb 24, 2022
Merged

Change fractal output directory to standard Federalist setup.#4532
thisisdano merged 2 commits into
developfrom
jm-update-federalist-develop

Conversation

@mejiaj

@mejiaj mejiaj commented Feb 24, 2022

Copy link
Copy Markdown
Contributor

Description

Updated Federalist setup. This PR updates the Federalist process to use the latest and standard setup. This closes #4519.

Additional information

Previously we depended on a _config.yml to point Federalist to the generated output to properly deploy. This causes 2 issues:

  1. That's no longer necessary and will be deprecated in the future.
  2. Builds take longer than necessary, run out of memory, and are prone to crashing.

More info in slack conversation.

Related issues

Related to issue #4520.

⚠️ Note: Once both issues are closed we need to go into Federalist and update the Site Engine field from Jekyll → Node.

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj mejiaj marked this pull request as ready for review February 24, 2022 18:01
@thisisdano thisisdano merged commit 4945467 into develop Feb 24, 2022
@thisisdano thisisdano deleted the jm-update-federalist-develop branch February 24, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Federalist set-up on Main

2 participants