Post Getting Started Updates_Nov 30, 2021#4412
Merged
Merged
Conversation
The following updates have been made to remove redundancies with the updated Getting Started guidance for developers and per conversation with the dev team: –"Download and install" has been made more specific: "Download and install without npm." –"Install using npm" has been removed. References to this section have tentatively been replaced with "NEW LINK," and prior to publication, will be replaced with the link to the updated web guidance for Getting Started for devs. –Content of "Use another framework or package manager" has been moved up to appear under "Using the design system." –"Accessibility" has been updated to note a few of the tools we use to ensure USWDS is accessible.
Added link to new dev guidance
4 tasks
mejiaj
reviewed
Dec 8, 2021
mejiaj
reviewed
Dec 8, 2021
Contributor
There was a problem hiding this comment.
Looks good! But we need to find a solution for SASS Requirements section.
You can view what the page would like like on the doc's site here →.
I've also updated the links to point to new sections in the Maturity Model page.
Co-authored-by: James Mejia <james.mejia@gsa.gov>
thisisdano
approved these changes
Dec 9, 2021
thisisdano
suggested changes
Dec 9, 2021
thisisdano
left a comment
Contributor
There was a problem hiding this comment.
Let's make the change James suggested and then we can merge.
Contributor
Author
|
James suggestion was incorporated as part of this PR in the site repo: https://github.com/uswds/uswds-site/pull/1370/files |
mejiaj
approved these changes
Jan 31, 2022
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thank you @mikki-stacey!
mejiaj
approved these changes
Mar 9, 2022
thisisdano
approved these changes
Mar 9, 2022
mejiaj
pushed a commit
that referenced
this pull request
Apr 8, 2022
Post Getting Started Updates_Nov 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include a high-level description of the issue your pull request fixes; include only one issue per pull request. Please also link to the GitHub issue it resolves.
Additional information
Include any of the following (as necessary):
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.