Skip to content

USWDS Footer - bug fix: reveal hidden content at 480px window width#4531

Merged
thisisdano merged 2 commits into
developfrom
al-collapsible-480-bug
Mar 1, 2022
Merged

USWDS Footer - bug fix: reveal hidden content at 480px window width#4531
thisisdano merged 2 commits into
developfrom
al-collapsible-480-bug

Conversation

@amyleadem

@amyleadem amyleadem commented Feb 24, 2022

Copy link
Copy Markdown
Contributor

Description

From jkjustjoshing in issue #4524

The CSS to switch between the collapsed and expanded view of the "big footer" uses the media query (min-width: 30em) but the Javascript uses the media query (max-width: 30em). This causes an edge case at exactly 30em (480px) viewport width.

Resolution

To get expected behavior at 30em(480px), we must allow min-width rules to dominate and reset the max-width value to be 1px less than the breakpoint.

Also fixed the cursor behavior on the headers when the content is not collapsed (and the headers are no longer actionable)

Closes #4524

@amyleadem amyleadem changed the title Footer bug fix: reveal collapsed content at 480px window width USWDS Footer - bug fix: reveal hidden content at 480px window width Feb 24, 2022
@amyleadem amyleadem marked this pull request as ready for review February 24, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Footer] At exactly 480px viewport width, collapsable components display incorrectly

2 participants