Release 2.12.1#4291
Merged
Merged
Conversation
…ark/uswds into seanpclark-date-picker-non-empty-id
ANDI issue: Aria-hidden alerts. The element is being hidden from screenreaders anyways. Using `sr-only` class here could be potentially confusing.
**Why**: It's expected to be a standalone script. Bundler adds overhead in compiled output.
Sync develop (2.12.0)
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
[USWDS]: Optimize initializer script
USWDS - Date picker: Remove empty attrs.
Account for cases where page content changes after initial script load, including: - If USWDS script is loaded early in page content, all server-rendered content to follow will not be counted as non-modal content - If any JavaScript alters the page after load, this will not be counted as non-modal content
USWDS - Range: add ARIA attribute.
Modal: Fix modal aria-hidden for non-modal content after script load
Date Picker / Combo Box: Use mouseover event instead of mousemove
USWDS: Breadcrumb - Changes negative margin from shorthand to left/right
- Added test case in navigation.spec.js - Updated navigation.js to accept `Esc` key to close nav and dropdowns
- Eslint fix for config/gulp/test.js - Close active navigation on focusout - Add events to navigation tests for `focusout` and `escape` - Add test for collapsing nav on focusout
"Alt text" is bad alt text
Let's minimize default images
Avoids issues where HTML spacing is sensitive between the checkmark pseudo-element and label text.
Since otherwise the end-result could possibly be an invalid size token
USWDS - Navigation: Close actions.
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
So that checkbox positioning is accurate based on explicit font expectations
Checkbox / Radio Button: Improve HTML whitespace sensitivity
[USWDS] COMBOBOX | Fix textContent combobox
[USWDS] Modal | return early if no modal
Update dependencies and refs
mejiaj
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in USWDS 2.12.1
Improvements and bug fixes
escor focusing out will close dropdown menus in the header. (USWDS - Navigation: Close actions. #4275)usa-checkbox__labelorusa-radio__label#4262)optiontext. Thanks @aduth! ([USWDS] COMBOBOX | Fix textContent combobox #4287)uswds-initscript. Thanks @aduth! ([USWDS]: Optimize initializer script #4243)A big thank you to @aduth for all his work on many of the PRs in this release.
Security and dependencies
Dependencies
0vulnerabilities in regular dependencies (dependencies for USWDS projects installed withnpm install uswds)5 low, 5 moderate, 3 highvulnerabilities in devDependencies (development dependencies)Release ZIP SHA-256 hash:
4492423dacfe6cf4f383cb2e436203c9f6b4caf302850b97bf8b6c81712312fa