[USWDS]: Optimize initializer script#4243
Merged
Merged
Conversation
**Why**: It's expected to be a standalone script. Bundler adds overhead in compiled output.
Contributor
Author
|
@mejiaj can you please pull this locally and test it in IE for us? |
Contributor
|
@gscottqueen class is correctly added and removed on IE11. |
mejiaj
approved these changes
Jun 28, 2021
aduth
reviewed
Jun 30, 2021
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Contributor
Author
|
@thisisdano ready for your review |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds off and closes #4233
[USWDS] Optimize initializer script
We are trying to stay away from gulp dependencies, and the recommended wrapper approach worked well. However, it does make the code a bit more complex and harder to read.
This PR works to take advantage of the recommended es5 refactor approach from #4233 (comment), while keeping the added value proposed by @aduth
npm testand make sure the tests for the files you have changed have passed.