USWDS: Breadcrumb - Checkbox/radio components don't work if label class doesn't end with usa-checkbox__label or usa-radio__label#4262
Merged
Conversation
|
this pull request fixed it on my site, I approve |
jrglasgow
approved these changes
Jul 29, 2021
thisisdano
approved these changes
Jul 30, 2021
thisisdano
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Nice fix. Thank you!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4251.
Description
Resolves a Sass selector issue where checkbox and radio components were only being styled if the
usa-*__labelwas the last CSS class. One would expect this should work if the CSS class is present within the element regardless of position, due to modifiers and application-specific overrides or expansions.Additional information
See #4251 for the original report and suggested fix.
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.