USWDS - Date picker: Remove empty attrs.#4218
Merged
Merged
Conversation
mejiaj
commented
Jun 7, 2021
| ); | ||
| internalInputEl.id = ""; | ||
| internalInputEl.removeAttribute("id"); | ||
| internalInputEl.removeAttribute("name"); |
Contributor
Author
There was a problem hiding this comment.
Not breaking, but was leaving an empty name attribute. Went ahead and removed it.
ANDI issue: Aria-hidden alerts. The element is being hidden from screenreaders anyways. Using `sr-only` class here could be potentially confusing.
mejiaj
commented
Jun 7, 2021
| DATE_PICKER_INTERNAL_INPUT_CLASS | ||
| ); | ||
| internalInputEl.id = ""; | ||
| internalInputEl.style.display = "none"; |
Contributor
Author
There was a problem hiding this comment.
Removed the sr-only class and hiding it via display: none instead. This resolves an ANDI issue that was flagged about hidden focusable elements.
Error USWDS 2.11.2
Contributor
Author
|
Other ANDI issues:
Removed negative tabindex in c76974e.
The icon is set via background on the button. We could move that into an inner span like we did on the footer social icon nav in #4211
|
thisisdano
approved these changes
Jul 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds on the work from @seanpclark in #4200. Additionally removes empty name attribute.
Additional information
TK
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.