USWDS - Footer: Move social icon images into their own element.#4211
Merged
Conversation
added 2 commits
May 27, 2021 12:30
4 tasks
Closed
2 tasks
Contributor
Author
|
Odd, locally it builds fine. But on federalist |
Contributor
Author
|
We only have the search icon to fix in header besides the social nav icons in footer. Found background images in Core component. Images related to functionality in bold: Banner
Header
Footer
IdentifierNone |
aduth
reviewed
Jul 20, 2021
thisisdano
suggested changes
Jul 20, 2021
Contributor
Author
|
Thanks for the feedback! Updated markup in big variant to match. |
thisisdano
reviewed
Jul 21, 2021
thisisdano
left a comment
Contributor
There was a problem hiding this comment.
LGTM — Holding til next minor release
thisisdano
approved these changes
Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #4207.
Improved accessibility of USA Footer's social nav. Social icons were converted to inline images with
alttext to ensure there's a meaningful text alternative.⚠ Requires a manual change to Footer's social navigation.
New markup
Old markup
Preview links
Footer (default) →
Footer Big →
Additional information
The reported ANDI issue USWDS <= 2.12.0.
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.