Modal: Fix modal aria-hidden for non-modal content after script load#4269
Merged
Conversation
Account for cases where page content changes after initial script load, including: - If USWDS script is loaded early in page content, all server-rendered content to follow will not be counted as non-modal content - If any JavaScript alters the page after load, this will not be counted as non-modal content
mejiaj
reviewed
Jul 19, 2021
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
Minor comment about the NON_MODALS selector. Otherwise LGTM, thanks for submitting this!
mejiaj
approved these changes
Jul 20, 2021
thisisdano
approved these changes
Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Accounts for cases where page content changes after initial script load, including:
Additional information
Because
nonModalswas assigned only once at script load, it would not include anything from the above scenarios.Notably, this means that users navigating page content using assistive technology can often escape the modal, which is not the intended behavior.
The newly-added test cases will fail on the
developbranch, because this issue is also present in the tests.Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.