*: use kvproto::backup::StorageBackend in create_storage#6186
Merged
sre-bot merged 5 commits intotikv:masterfrom Dec 9, 2019
Merged
*: use kvproto::backup::StorageBackend in create_storage#6186sre-bot merged 5 commits intotikv:masterfrom
sre-bot merged 5 commits intotikv:masterfrom
Conversation
549c67d to
86bd104
Compare
Signed-off-by: kennytm <kennytm@gmail.com>
86bd104 to
921295e
Compare
Contributor
Author
|
/run-all-tests |
Contributor
Author
| u | ||
| } | ||
|
|
||
| /// Creates a local `StorageBackend` to the given path. |
There was a problem hiding this comment.
S3 backend is not covered in this PR?
Contributor
Author
There was a problem hiding this comment.
Right, that would be another PR.
Signed-off-by: kennytm <kennytm@gmail.com>
Contributor
|
/run-all-tests |
Contributor
|
@kennytm merge failed. |
Member
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
@kennytm merge failed. |
Contributor
Author
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
@kennytm merge failed. |
Contributor
Author
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
cherry pick to release-3.1 failed |
kennytm
added a commit
to kennytm/tikv
that referenced
this pull request
Dec 10, 2019
Signed-off-by: kennytm <kennytm@gmail.com>
overvenus
pushed a commit
that referenced
this pull request
Dec 10, 2019
c1ay
pushed a commit
to c1ay/tikv
that referenced
this pull request
May 9, 2020
Signed-off-by: kennytm <kennytm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What have you changed?
Please explain in detail what the changes are in this PR and why they are needed:
backup::BackupRequestandimport_sstpb::DownloadRequestrespectively, and replaced them with a structural typebackup::StorageBackend, so that storage with multiple options (e.g. S3) can be passed without unnecessary deserialization.kvprototo include that change.external_storage::create_storagefunction is updated to take a&backup::StorageBackendinstead of&strbackupandsst_importercomponents and test cases are updated accordingly.What is the type of the changes?
Pick one of the following and delete the others:
How is the PR tested?
Please select the tests that you ran to verify your changes:
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No
Does this PR affect
tidb-ansible?No
Refer to a related PR or issue link (optional)
pingcap/kvproto#507
pingcap/br#88
Benchmark result if necessary (optional)
Any examples? (optional)