backup: extend backup storage for S3#507
Merged
kennytm merged 6 commits intopingcap:masterfrom Dec 5, 2019
Merged
Conversation
|
|
Signed-off-by: tennix <ztennix@gmail.com>
5706edf to
dc0e11d
Compare
tennix
commented
Dec 4, 2019
kennytm
reviewed
Dec 4, 2019
Signed-off-by: tennix <ztennix@gmail.com>
64c5987 to
4ce8f96
Compare
kennytm
reviewed
Dec 4, 2019
| } | ||
| } | ||
|
|
||
| message S3 { |
Contributor
There was a problem hiding this comment.
No need for provider?
Member
Author
There was a problem hiding this comment.
Yes, we can treat non-AWS providers as custom providers, and enfore to provide endpoint.
Contributor
There was a problem hiding this comment.
OK, by enforce, we can only make it clear in the document, right? We cannot enforce it in code without provider.
Signed-off-by: tennix <ztennix@gmail.com>
ac21b35 to
68ee98a
Compare
Signed-off-by: tennix <ztennix@gmail.com>
kennytm
previously approved these changes
Dec 5, 2019
overvenus
reviewed
Dec 5, 2019
Signed-off-by: tennix <ztennix@gmail.com>
Signed-off-by: tennix <ztennix@gmail.com>
kennytm
approved these changes
Dec 5, 2019
9 tasks
kennytm
added a commit
that referenced
this pull request
Dec 10, 2019
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> Co-authored-by: Tennix <tennix@users.noreply.github.com> Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
added a commit
that referenced
this pull request
Dec 10, 2019
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> Co-authored-by: Tennix <tennix@users.noreply.github.com> Signed-off-by: kennytm <kennytm@gmail.com>
daimashusheng
pushed a commit
to daimashusheng/kvproto
that referenced
this pull request
Sep 2, 2021
* extend backup storage for S3 Signed-off-by: tennix <ztennix@gmail.com> * address comment Signed-off-by: tennix <ztennix@gmail.com> * use empty message for noop storage backend Signed-off-by: tennix <ztennix@gmail.com> * Generate Go code Signed-off-by: tennix <ztennix@gmail.com> * Deprecate local_path Signed-off-by: tennix <ztennix@gmail.com> * Make StorageBackend a standalone message type Signed-off-by: tennix <ztennix@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tennix ztennix@gmail.com
Extend backup storage to use support extra storage backend to avoid encoding all parameters in the
pathfield as URL format.Note: I'll generate the code in another commit once the protobuf definition is approved to make the review easier.